From: Tang Yuantian <Yuantian.Tang@freescale.com>
To: <tj@kernel.org>
Cc: <hdegoede@redhat.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-ide@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Tang Yuantian <Yuantian.Tang@freescale.com>
Subject: [PATCH 2/3] ahci: qoriq: Disable NCQ on ls2080a SoC
Date: Thu, 29 Oct 2015 14:22:16 +0800 [thread overview]
Message-ID: <1446099737-41854-2-git-send-email-Yuantian.Tang@freescale.com> (raw)
In-Reply-To: <1446099737-41854-1-git-send-email-Yuantian.Tang@freescale.com>
NCQ feature can't be used due to the erratum A-008473.
This patch disabled NCQ as a workaround.
Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
---
drivers/ata/ahci_qoriq.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c
index b9b691e..686d804 100644
--- a/drivers/ata/ahci_qoriq.c
+++ b/drivers/ata/ahci_qoriq.c
@@ -131,7 +131,7 @@ static struct ata_port_operations ahci_qoriq_ops = {
.hardreset = ahci_qoriq_hardreset,
};
-static const struct ata_port_info ahci_qoriq_port_info = {
+static struct ata_port_info ahci_qoriq_port_info = {
.flags = AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
.pio_mask = ATA_PIO4,
.udma_mask = ATA_UDMA6,
@@ -208,6 +208,12 @@ static int ahci_qoriq_probe(struct platform_device *pdev)
if (rc)
goto disable_resources;
+ /* Workaround for ls2080a */
+ if (qoriq_priv->type == AHCI_LS2080A) {
+ hpriv->flags |= AHCI_HFLAG_NO_NCQ;
+ ahci_qoriq_port_info.flags &= ~(ATA_FLAG_NCQ);
+ }
+
rc = ahci_platform_init_host(pdev, hpriv, &ahci_qoriq_port_info,
&ahci_qoriq_sht);
if (rc)
--
2.1.0.27.g96db324
next prev parent reply other threads:[~2015-10-29 6:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 6:22 [PATCH 1/3] ahci: qoriq: Rename LS2085A SoC support code to LS2080A Tang Yuantian
2015-10-29 6:22 ` Tang Yuantian [this message]
2015-10-29 6:22 ` [PATCH 3/3] devicetree: bindings: Fixed a few typos Tang Yuantian
2015-10-31 0:53 ` [PATCH 1/3] ahci: qoriq: Rename LS2085A SoC support code to LS2080A Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446099737-41854-2-git-send-email-Yuantian.Tang@freescale.com \
--to=yuantian.tang@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®