From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964897AbbJ2QO4 (ORCPT ); Thu, 29 Oct 2015 12:14:56 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:41653 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757242AbbJ2QOx (ORCPT ); Thu, 29 Oct 2015 12:14:53 -0400 Message-ID: <1446135292.3274.67.camel@pengutronix.de> Subject: Re: [PATCH V6 2/3] Add reset controller for hi6220 SoC platform. From: Philipp Zabel To: Chen Feng Cc: linux-kernel@vger.kernel.org, puck.chen@aliyun.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk Date: Thu, 29 Oct 2015 17:14:52 +0100 In-Reply-To: <1446123303-91956-2-git-send-email-puck.chen@hisilicon.com> References: <1446123303-91956-1-git-send-email-puck.chen@hisilicon.com> <1446123303-91956-2-git-send-email-puck.chen@hisilicon.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 29.10.2015, 20:55 +0800 schrieb Chen Feng: > reset: add driver for hi6220 reset controller Same comment as for patch 1, this should probably be the subject, the commit message body was better in V4. > Signed-off-by: Chen Feng > --- > drivers/reset/Kconfig | 1 + > drivers/reset/Makefile | 1 + > drivers/reset/hisilicon/Kconfig | 5 ++ > drivers/reset/hisilicon/Makefile | 1 + > drivers/reset/hisilicon/hi6220_reset.c | 108 +++++++++++++++++++++++++ > include/dt-bindings/reset/hisi,hi6220-resets.h | 67 +++++++++++++++ Move the header file into patch 1, it is better to include this with the binding documentation. regards Philipp