From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751859AbbJaWDL (ORCPT ); Sat, 31 Oct 2015 18:03:11 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36377 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbbJaWDH (ORCPT ); Sat, 31 Oct 2015 18:03:07 -0400 From: Bogicevic Sasa To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Bogicevic Sasa Subject: [PATCH] drivers:staging:gdm72xx Fix increment in a loop Date: Sat, 31 Oct 2015 23:03:00 +0100 Message-Id: <1446328980-1016-1-git-send-email-brutallesale@gmail.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fixes increment of pos int to be more readable Lines qcb->csr[index].srcport_lo = ((buf[pos++]<<8)&0xff00); qcb->csr[index].srcport_lo += buf[pos++]; become qcb->csr[index].srcport_lo = get_unaligned_le16(&buf[pos]); pos += 2; Signed-off-by: Bogicevic Sasa --- drivers/staging/gdm72xx/gdm_qos.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c index 44d04bd..132789c 100644 --- a/drivers/staging/gdm72xx/gdm_qos.c +++ b/drivers/staging/gdm72xx/gdm_qos.c @@ -406,14 +406,14 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size) qcb->csr[index].ipdst_addr[1] = buf[pos++]; qcb->csr[index].ipdst_addr[2] = buf[pos++]; qcb->csr[index].ipdst_addr[3] = buf[pos++]; - qcb->csr[index].srcport_lo = ((buf[pos++] << 8) & 0xff00); - qcb->csr[index].srcport_lo += buf[pos++]; - qcb->csr[index].srcport_hi = ((buf[pos++] << 8) & 0xff00); - qcb->csr[index].srcport_hi += buf[pos++]; - qcb->csr[index].dstport_lo = ((buf[pos++] << 8) & 0xff00); - qcb->csr[index].dstport_lo += buf[pos++]; - qcb->csr[index].dstport_hi = ((buf[pos++] << 8) & 0xff00); - qcb->csr[index].dstport_hi += buf[pos++]; + qcb->csr[index].srcport_lo = get_unaligned_le16(&buf[pos]); + pos += 2; + qcb->csr[index].srcport_hi = get_unaligned_le16(&buf[pos]); + pos += 2; + qcb->csr[index].dstport_lo = get_unaligned_le16(&buf[pos]); + pos += 2; + qcb->csr[index].dstport_hi = get_unaligned_le16(&buf[pos]); + pos += 2; qcb->qos_limit_size = 254 / qcb->qos_list_cnt; spin_unlock_irqrestore(&qcb->qos_lock, flags); -- 2.1.4