From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752323AbbKCMsG (ORCPT ); Tue, 3 Nov 2015 07:48:06 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:36566 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750887AbbKCMsD (ORCPT ); Tue, 3 Nov 2015 07:48:03 -0500 Message-ID: <1446554880.23275.53.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: Resource leak in unshare From: Eric Dumazet To: Dmitry Vyukov Cc: syzkaller , David Miller , Nicolas Dichtel , Al Viro , Thomas Graf , Cong Wang , netdev , LKML , Alexey Kuznetsov , jmorris@namei.org, yoshfuji@linux-ipv6.org, Patrick McHardy , Kostya Serebryany , Alexander Potapenko , Eric Dumazet , Kees Cook , Julien Tinnes , Sasha Levin Date: Tue, 03 Nov 2015 04:48:00 -0800 In-Reply-To: References: <87oafcrzsa.fsf@x220.int.ebiederm.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-11-03 at 09:48 +0100, Dmitry Vyukov wrote: > On Mon, Nov 2, 2015 at 8:01 PM, Eric W. Biederman wrote: > > Dmitry Vyukov writes: > > > >> Hello, > >> > >> I am hitting the following warnings on > >> bcee19f424a0d8c26ecf2607b73c690802658b29 (4.3): > > > > Do you have any trace of the earlier failures? > > > > This appears to be something caused by an earlier failure (possibly > > whatever fails to allocate memory). Having network devices present > > but being in the generic cleanup routines is wrong. > > > > If there is no additional information can you please rerun with the > > following change applied? That should at least report which function is > > failing, and give us a good clue where to start debugging this. > > > So is it all fixed now? Or it is still clear how it can happen? > Eric (Dumazet), do you see how the WARNING can fire? > I don't have any logs at the moment, but I can run fuzzer for longer > to reproduce it again if necessary. No idea. I fixed a completely different bug I think, while simply looking at sit code, since your report mentioned a sit0 name. Namely a pure memory leak. We have hundred of old bugs yet to fix. Not counting the new ones that we'll add while fixing them. Feel free to run your fuzzer of course.