From: Saurabh Sengar <saurabh.truth@gmail.com>
To: matt@codeblueprint.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi: replace GFP_KERNEL with GFP_ATOMIC
Date: Tue, 3 Nov 2015 23:08:46 +0530 [thread overview]
Message-ID: <1446572326-5831-1-git-send-email-saurabh.truth@gmail.com> (raw)
In-Reply-To: <20151103163650.GE2653@codeblueprint.co.uk>
>It's slightly winding code, but if you look at the callers of
>efivar_init() you'll see that none of them set both 'atomic' and
>'duplicates', so dup_variable_bug() will never be called while holding
>a spinlock.
>Or am I missing something?
I was assuming that there could be a possibility when both 'atomic' and 'duplicates' are set.
If both can never be set, then this patch does not make any sense, you are correct.
Thank you for review
next prev parent reply other threads:[~2015-11-03 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 3:42 [PATCH v2] " Saurabh Sengar
2015-11-03 16:36 ` Matt Fleming
2015-11-03 17:38 ` Saurabh Sengar [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-10-27 18:42 [PATCH] " Saurabh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446572326-5831-1-git-send-email-saurabh.truth@gmail.com \
--to=saurabh.truth@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome