mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H . Peter Anvin" <hpa@zytor.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	Andy Lutomirski <luto@amacapital.net>,
	Borislav Petkov <bp@alien8.de>,
	"Huang, Ying" <ying.huang@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	stable@vger.kernel.org
Subject: [GIT PULL] EFI urgent fix
Date: Wed,  4 Nov 2015 10:47:16 +0000	[thread overview]
Message-ID: <1446634037-10251-1-git-send-email-matt@codeblueprint.co.uk> (raw)

Folks, the LKP robot reported an issue with Paolo's recent bug fix
that syncs the identity mapping in 'initial_page_table'. Turns out
that KERNEL_PGD_PTRS is not the correct constant to use when copying
to the lower region because that's every PGD from PAGE_OFFSET to the
end of the addressable memory.

Crucially, KERNEL_PGD_PTRS > KERNEL_PGD_BOUNDARY and so the patch ends
up trashing some of the kernel mappings in 'initial_page'table,
leading to boot crashes on 32-bit SMP when bringing APs online.

The following changes since commit 9ee870feaa9e0c6abef95a3b1fc518d88adfa2d3:

  Merge branch 'x86/cpufeature' into x86/urgent, to pick up pending Intel MID change (2015-11-03 12:00:40 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/mfleming/efi.git tags/efi-urgent

for you to fetch changes up to 5965d1bbeba70fe3626e4537f4729283cb0e75f7:

  x86/setup: Fix recent boot crash on 32-bit SMP machines (2015-11-04 09:26:24 +0000)

----------------------------------------------------------------
 * Avoid trashing the kernel mappings in 'initial_page_table' when
   copying the identity mapping from 'swapper_pg_dir'. This bug was
   introduced by a bug fix in v4.3 which erroneously copies too many
   entries from 'swapper_pg_dir'.

----------------------------------------------------------------
Matt Fleming (1):
      x86/setup: Fix recent boot crash on 32-bit SMP machines

 arch/x86/kernel/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

             reply	other threads:[~2015-11-04 10:47 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 10:47 Matt Fleming [this message]
2015-11-04 10:47 ` [PATCH] x86/setup: Fix recent boot crash on 32-bit SMP machines Matt Fleming
2015-11-04 10:50 ` [GIT PULL] EFI urgent fix Thomas Gleixner
  -- strict thread matches above, loose matches on Subject: below --
2017-04-12 15:27 Matt Fleming
2017-01-27 22:06 Matt Fleming
2016-05-13 20:34 Matt Fleming
2016-04-25 11:26 Matt Fleming
2016-04-25 15:29 ` Ingo Molnar
2016-04-01 19:03 Matt Fleming
2016-04-02  7:32 ` Ingo Molnar
2015-10-16 10:01 Matt Fleming
2015-10-16 10:04 ` Ingo Molnar
2015-10-12 14:13 Matt Fleming
2015-07-15 14:31 Matt Fleming
2015-07-21  7:53 ` Ingo Molnar
2015-06-11 12:47 Matt Fleming
2015-06-11 14:43 ` Ingo Molnar
2015-06-12 15:00   ` Matt Fleming
2015-03-27 19:18 Matt Fleming
2014-09-19 10:33 Matt Fleming
2014-09-19 10:50 ` Ingo Molnar
2014-08-06  9:46 Matt Fleming
2014-07-07  6:43 Matt Fleming
2014-06-20  9:00 Matt Fleming
2014-06-20  9:28 ` Catalin Marinas
2014-06-20 13:39   ` Leif Lindholm
2014-06-20 13:49     ` Matt Fleming
2014-06-20 14:19       ` Leif Lindholm
2014-06-25 20:42 ` Matt Fleming
2014-05-03  5:51 Matt Fleming
2014-05-04 18:21 ` Ingo Molnar
2014-03-04 23:47 Matt Fleming
2013-09-19 12:41 Matt Fleming
2013-09-20  7:53 ` Ingo Molnar
2013-06-21  9:56 Matt Fleming
2013-04-26 16:30 Matt Fleming
2013-04-26 16:40 ` Linus Torvalds
2013-04-26 16:48   ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446634037-10251-1-git-send-email-matt@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=lersek@redhat.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®