mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhou Chengming <zhouchengming1@huawei.com>
To: <jpoimboe@redhat.com>, <sjenning@redhat.com>, <jkosina@suse.cz>,
	<vojtech@suse.cz>
Cc: <live-patching@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<guohanjun@huawei.com>, <huawei.libin@huawei.com>,
	<xiexiuqi@huawei.com>, <cbay@alwaysdata.com>,
	<zhouchengming1@huawei.com>
Subject: [PATCH v2] livepatch: x86: bugfix about kASLR
Date: Fri, 6 Nov 2015 14:25:00 +0800	[thread overview]
Message-ID: <1446791100-41585-1-git-send-email-zhouchengming1@huawei.com> (raw)

When enable KASLR, livepatch will adjust old_addr of changed
function accordingly. So do the same thing for reloc.

[PATCH v1] https://lkml.org/lkml/2015/11/4/91

Reported-by: Cyril B. <cbay@alwaysdata.com>
Signed-off-by: Zhou Chengming <zhouchengming1@huawei.com>
---
 kernel/livepatch/core.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index 6e53441..db545cb 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -294,6 +294,12 @@ static int klp_write_object_relocations(struct module *pmod,
 
 	for (reloc = obj->relocs; reloc->name; reloc++) {
 		if (!klp_is_module(obj)) {
+
+#if defined(CONFIG_RANDOMIZE_BASE)
+			/* If KASLR has been enabled, adjust old value accordingly */
+			if (kaslr_enabled())
+				reloc->val += kaslr_offset();
+#endif
 			ret = klp_verify_vmlinux_symbol(reloc->name,
 							reloc->val);
 			if (ret)
-- 
1.7.7


             reply	other threads:[~2015-11-06  6:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06  6:25 Zhou Chengming [this message]
2015-11-10 14:07 ` Josh Poimboeuf
2015-11-11  8:46   ` Minfei Huang
2015-11-11 16:15     ` Josh Poimboeuf
2015-11-11 16:19       ` Jiri Kosina
2015-11-11 16:20         ` Josh Poimboeuf
2015-11-11 16:26 ` Josh Poimboeuf
2015-11-11 16:39 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446791100-41585-1-git-send-email-zhouchengming1@huawei.com \
    --to=zhouchengming1@huawei.com \
    --cc=cbay@alwaysdata.com \
    --cc=guohanjun@huawei.com \
    --cc=huawei.libin@huawei.com \
    --cc=jkosina@suse.cz \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=sjenning@redhat.com \
    --cc=vojtech@suse.cz \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®