From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033292AbbKFMiL (ORCPT ); Fri, 6 Nov 2015 07:38:11 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:55847 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752346AbbKFMiH (ORCPT ); Fri, 6 Nov 2015 07:38:07 -0500 X-AuditID: cbfee690-f794e6d0000014de-56-563c9f2c5491 From: Vishnu Pratap Singh To: axboe@kernel.dk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, jmoyer@redhat.com, minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, davem@davemloft.net, neilb@suse.com, ulf.hansson@linaro.org, tiwai@suse.de, hare@suse.de, ming.lei@canonical.com, jarod@redhat.com, viro@zeniv.linux.org.uk, tj@kernel.org, adrian.hunter@intel.com, jonathanh@nvidia.com, grundler@chromium.org, linux-ide@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org Cc: cpgs@samsung.com, vishu13285@gmail.com, pintu.k@samsung.com, rohit.kr@samsung.com, Vishnu Pratap Singh Subject: [PATCH 7/8] cdrom/gdrom.c: handle add_disk() return value Date: Fri, 06 Nov 2015 17:52:14 +0530 Message-id: <1446812535-10567-7-git-send-email-vishnu.ps@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1446812535-10567-1-git-send-email-vishnu.ps@samsung.com> References: <437969438-9181-1-git-send-email-vishnu.ps@samsung.com> <1446812535-10567-1-git-send-email-vishnu.ps@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRmVeSWpSXmKPExsWyRsSkWld3vk2Ywfq1LBYnn6xhs5izHkis vtvPZvHykKbFnPMtLBavjvxgstizaBKTxbSeS4wWZ39dZbFombWIxeLYjkdMFpd3zWGzOPK/ n9Giff4uRotlX9+zW+x6+J3d4tPGWIsNLbPYLfq+H2a3eN7cymLxaALQkJeb3zBZ/Fp+lNHi +Npwi/N/j7NaTOm7y2ixZcVDVgdpj1kNvWwesxsusnhsWXmTyWPnrLvsHov3vGTyuHy21GPT qk42jzvX9rB5nJjxm8Wjt/kdm8f7fVfZPPq2rGL0WL/lKovH5tPVHjs/bWb1+LxJLkAwissm JTUnsyy1SN8ugStjxb1nrAXv2Sv2fbnP2MB4mK2LkZNDQsBEYt2v7+wQtpjEhXvrgeJcHEIC Kxgllq+YxgxTtGP9HXaIxFJGifUzF0I5TUwSza+uMIJUsQkYSmyYfQQsISLwm1lixoJ+MIdZ oIVRYurpdUwgVcICThJT//4EW84ioCqxcv4csDivgKvEt3/PoPbJSZw8Npm1i5GDg1PATeLh YbASIYF6iT8TdkDd+oNDYltHEMQYAYlvkw+xgJRLCMhKbDoANUVS4uCKGywTGIUXMDKsYhRN LUguKE5KLzLRK07MLS7NS9dLzs/dxAhMCqf/PZuwg/HeAetDjAIcjEo8vAbLrcOEWBPLiitz DzGaAm2YyCwlmpwPTD15JfGGxmZGFqYmpsZG5pZmSuK8r6V+BgsJpCeWpGanphakFsUXleak Fh9iZOLglGpgXF225eC/tevbvC6dkj57uLJky6tvS1WOMD0Ut1ljo7omb0OGlbhWeLmNm0NF 2+YDzlt91BXme0tqPd7EM9+06Ptcu5Rotm1XfjGJu9qffDC/6jj/ogffG8/W8ERzm55ddHtp PUOKVfSifbN10y1zq/h2am/5uGRz89/9Kl+nF0bMUNK8VXcjRImlOCPRUIu5qDgRAOOPQG0F AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrAKsWRmVeSWpSXmKPExsVy+t9jAV2d+TZhBs1vTS1OPlnDZjFnPZBY fbefzeLlIU2LOedbWCxeHfnBZLFn0SQmi2k9lxgtzv66ymLRMmsRi8WxHY+YLC7vmsNmceR/ P6NF+/xdjBbLvr5nt9j18Du7xaeNsRYbWmaxW/R9P8xu8by5lcXi0QSgIS83v2Gy+LX8KKPF 8bXhFuf/Hme1mNJ3l9Fiy4qHrA7SHrMaetk8ZjdcZPHYsvImk8fOWXfZPRbvecnkcflsqcem VZ1sHneu7WHzODHjN4tHb/M7No/3+66yefRtWcXosX7LVRaPzaerPXZ+2szq8XmTXIBgVAOj TUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg4wdJQUyhJz SoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhDWMGSvuPWMteM9ese/LfcYGxsNsXYyc HBICJhI71t9hh7DFJC7cWw8U5+IQEljKKLF+5kJ2CKeJSaL51RVGkCo2AUOJDbOPgCVEBH4z S8xY0A/mMAu0MEpMPb2OCaRKWMBJYurfn2A7WARUJVbOnwMW5xVwlfj27xkzxD45iZPHJrN2 MXJwcAq4STw8DFYiJFAv8WfCDvYJjLwLGBlWMUqkFiQXFCel5xrlpZbrFSfmFpfmpesl5+du YgSnnmfSOxgP73I/xCjAwajEw2uw3DpMiDWxrLgy9xCjBAezkgivHLNNmBBvSmJlVWpRfnxR aU5q8SFGU6C7JjJLiSbnA9NiXkm8obGJuamxqaWJhYmZpZI4r76nUZiQQHpiSWp2ampBahFM HxMHp1QDo7uCvfLV6viekzGf/3TXTOy2jestKuybsVuQTfvHnw3vAozt1x4W5WsLZXX+uDEh /NByl9NpWbWqR1pZL9er37R4Y671eUGzm8s+mc1X2aLXuHG9/dloFqqhd9/Uauey5T7B77kZ 3/l8Ox8qkqNa0qjouPAI/wblKs2/0U6hx+KLHJ6v0BFTYinOSDTUYi4qTgQAWmlaTFMDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch handles add_disk() return value. Earlier add_disk() function doesn't handle error cases, now it is added, so the callers of this function should also handle it. Verfied on X86 based ubuntu machine. This patch depends on [PATCH 1/8] block/genhd.c: Add error handling Signed-off-by: Vishnu Pratap Singh --- drivers/cdrom/gdrom.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c index 584bc31..38ca43a 100644 --- a/drivers/cdrom/gdrom.c +++ b/drivers/cdrom/gdrom.c @@ -817,9 +817,14 @@ static int probe_gdrom(struct platform_device *devptr) gd.toc = kzalloc(sizeof(struct gdromtoc), GFP_KERNEL); if (!gd.toc) goto probe_fail_toc; - add_disk(gd.disk); + err = add_disk(gd.disk); + if (err) + goto probe_fail_add_disk; + return 0; +probe_fail_add_disk: + kfree(gd.toc); probe_fail_toc: blk_cleanup_queue(gd.gdrom_rq); probe_fail_requestq: -- 1.9.1