From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752865AbbKHJiz (ORCPT ); Sun, 8 Nov 2015 04:38:55 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:57325 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751612AbbKHJit (ORCPT ); Sun, 8 Nov 2015 04:38:49 -0500 Message-ID: <1446975509.6006.116.camel@decadent.org.uk> Subject: Re: [PATCH 4.2 108/110] pinctrl: baytrail: Serialize all register access From: Ben Hutchings To: Greg Kroah-Hartman , Mika Westerberg Cc: stable@vger.kernel.org, Linus Walleij , Lucas De Marchi , LKML Date: Sun, 08 Nov 2015 09:38:29 +0000 In-Reply-To: <20151106191709.603097089@linuxfoundation.org> References: <20151106191703.247930828@linuxfoundation.org> <20151106191709.603097089@linuxfoundation.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-mZa0GjYKGK1Cmcfm9kOJ" X-Mailer: Evolution 3.18.1-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.247 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-mZa0GjYKGK1Cmcfm9kOJ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-11-06 at 11:19 -0800, Greg Kroah-Hartman wrote: > 4.2-stable review patch.=C2=A0=C2=A0If anyone has any objections, please = let me know. >=20 > ------------------ >=20 > From: Mika Westerberg >=20 > commit 39ce8150a079e3ae6ed9abf26d7918a558ef7c19 upstream. >=20 > There is a hardware issue in Intel Baytrail where concurrent GPIO registe= r > access might result reads of 0xffffffff and writes might get dropped > completely. >=20 > Prevent this from happening by taking the serializing lock in all places > where it is possible that more than one thread might be accessing the > hardware concurrently. [...] While I have no objection to this, I think a complete fix requires adding mmiowb() before each spin_unlock. Ben. --=20 Ben Hutchings 73.46% of all statistics are made up. --=-mZa0GjYKGK1Cmcfm9kOJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVj8YFee/yOyVhhEJAQrW6w/9GJXVrkrtgwTep8edq+xtkgtLZUG08in8 3kBimGyXW0vise+/4L3Rm4sgyF9noqQP5Dop4DzVzdvZZBiEG69UHsmamUDVLT4z Ns6i+gytYVqt28PeV7JG8hlgGbhJiAPvChZDz55iXMsHCDfEyZNR7ehpkd/3LoYt lcEPz9QEkZUheqcjcrFDJROOARiAZspxDlE376Xf6ZyniJOq/vU1nS7xCdG4no5Y /vx2sXDImgChkNaNGBTvyez+27Fr25TQLLxEblwTTHjm29BT2sZqDWS8yIdzPqb7 ibRyElteAh3A8sXUpK47uOGP38jQgQcNAhGgDyLwPhkta5Pl51kJOkTxipTtP8mp LNXiZMn/UGL4z6ku56ZK96ao44u+aOrPTpTdKcPxq9XHLeGcbULO+xKxEp/H46uA aahGjyjZbszIqjhDKD2rTidcn/CXaNkYBYTT8PlMjLnXLY2wn8QXRin6xGl67Hd8 idXXTjnksiHaJDRV/5UHwuKQnL6u6J8v7dTsIsfr36kADzdghika9Yeuu8cgspT8 tKR9a7WCK04iK7A+20VWEFGgdbLVM/Oj5EIBdMX8OpJyjEhumTvB+F+YDV7KQjQe pgy3LsO4xfS6KqNYwVQ9EQ23rb6BjyEnvHjfET2ZJSyntI8i9M7KlVBsabkaBoc9 N+ACiC1509s= =5WOb -----END PGP SIGNATURE----- --=-mZa0GjYKGK1Cmcfm9kOJ--