From: Caesar Wang <wxt@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>, Eduardo Valentin <edubezval@gmail.com>
Cc: linux-rockchip@lists.infradead.org, lkp@intel.com,
Caesar Wang <wxt@rock-chips.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 06/10] thermal: rockchip: consistently use int for temperatures
Date: Mon, 9 Nov 2015 12:48:58 +0800 [thread overview]
Message-ID: <1447044542-30859-7-git-send-email-wxt@rock-chips.com> (raw)
In-Reply-To: <1447044542-30859-1-git-send-email-wxt@rock-chips.com>
As Temperature is currently represented as int not long in the thermal
framework since use int intead of unsigned long/long to represent
temperature to avoid bogus overheat detection when negative temperature
reported.
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
---
Changes in v4:
- fix the warning from the print message.
Changes in v3:
- As the Patch v2 comments, Add a new patch to fix it.
Changes in v2: None
Changes in v1: None
drivers/thermal/rockchip_thermal.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index 7c5b784..73d47f8 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -88,7 +88,7 @@ struct rockchip_tsadc_chip {
int chn_num;
/* The hardware-controlled tshut property */
- long tshut_temp;
+ int tshut_temp;
enum tshut_mode tshut_mode;
enum tshut_polarity tshut_polarity;
@@ -101,7 +101,7 @@ struct rockchip_tsadc_chip {
int (*get_temp)(struct chip_tsadc_table table,
int chn, void __iomem *reg, int *temp);
void (*set_tshut_temp)(struct chip_tsadc_table table,
- int chn, void __iomem *reg, long temp);
+ int chn, void __iomem *reg, int temp);
void (*set_tshut_mode)(int chn, void __iomem *reg, enum tshut_mode m);
/* Per-table methods */
@@ -126,7 +126,7 @@ struct rockchip_thermal_data {
void __iomem *regs;
- long tshut_temp;
+ int tshut_temp;
enum tshut_mode tshut_mode;
enum tshut_polarity tshut_polarity;
};
@@ -160,7 +160,7 @@ struct rockchip_thermal_data {
struct tsadc_table {
u32 code;
- long temp;
+ int temp;
};
static const struct tsadc_table v2_code_table[] = {
@@ -202,7 +202,7 @@ static const struct tsadc_table v2_code_table[] = {
};
static u32 rk_tsadcv2_temp_to_code(struct chip_tsadc_table table,
- long temp)
+ int temp)
{
int high, low, mid;
@@ -356,7 +356,7 @@ static int rk_tsadcv2_get_temp(struct chip_tsadc_table table,
}
static void rk_tsadcv2_tshut_temp(struct chip_tsadc_table table,
- int chn, void __iomem *regs, long temp)
+ int chn, void __iomem *regs, int temp)
{
u32 tshut_value, val;
@@ -469,7 +469,7 @@ static int rockchip_configure_from_dt(struct device *dev,
if (of_property_read_u32(np, "rockchip,hw-tshut-temp", &shut_temp)) {
dev_warn(dev,
- "Missing tshut temp property, using default %ld\n",
+ "Missing tshut temp property, using default %d\n",
thermal->chip->tshut_temp);
thermal->tshut_temp = thermal->chip->tshut_temp;
} else {
@@ -477,7 +477,7 @@ static int rockchip_configure_from_dt(struct device *dev,
}
if (thermal->tshut_temp > INT_MAX) {
- dev_err(dev, "Invalid tshut temperature specified: %ld\n",
+ dev_err(dev, "Invalid tshut temperature specified: %d\n",
thermal->tshut_temp);
return -ERANGE;
}
--
1.9.1
next prev parent reply other threads:[~2015-11-09 4:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 4:48 [PATCH v4 00/10] Better compatible for the rockchip thermal and support RK3368 SoCs Caesar Wang
2015-11-09 4:48 ` [PATCH v4 01/10] dt-bindings: rockchip-thermal: Support the RK3368 SoCs compatible Caesar Wang
2015-11-09 4:48 ` [PATCH v4 02/10] thermal: rockchip: better to compatible the driver for different SoCs Caesar Wang
2015-11-09 4:48 ` [PATCH v4 03/10] thermal: rockchip: trivial: fix typo in commit Caesar Wang
2015-11-09 4:48 ` [PATCH v4 04/10] thermal: rockchip: improve the conversion function Caesar Wang
2015-11-09 4:48 ` [PATCH v4 05/10] thermal: rockchip: Add the sort mode for adc value increment or decrement Caesar Wang
2015-11-09 4:48 ` Caesar Wang [this message]
2015-12-02 18:38 ` [PATCH v4 06/10] thermal: rockchip: consistently use int for temperatures Brian Norris
[not found] ` <565F8FFE.3080807@rock-chips.com>
2015-12-03 0:49 ` Brian Norris
2015-12-03 1:16 ` Caesar Wang
2015-11-09 4:48 ` [PATCH v4 07/10] thermal: rockchip: Support the RK3368 SoCs in thermal driver Caesar Wang
2015-11-09 4:49 ` [PATCH v4 08/10] arm64: dts: Add the thermal data found on RK3368 Caesar Wang
2015-11-09 4:49 ` [PATCH v4 09/10] arm64: dts: Add main Thermal info to rk3368.dtsi Caesar Wang
2015-11-09 4:49 ` [PATCH v4 10/10] arm64: dts: Enable the Thermal on R88 board Caesar Wang
2015-11-12 18:29 ` [PATCH v4 00/10] Better compatible for the rockchip thermal and support RK3368 SoCs Eduardo Valentin
2015-11-12 18:31 ` Eduardo Valentin
2015-11-21 16:41 ` Heiko Stuebner
2015-11-12 22:14 ` Heiko Stuebner
2015-11-14 6:31 ` Caesar Wang
2015-11-14 6:30 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447044542-30859-7-git-send-email-wxt@rock-chips.com \
--to=wxt@rock-chips.com \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lkp@intel.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®