From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751885AbbKJDAi (ORCPT ); Mon, 9 Nov 2015 22:00:38 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:53584 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbbKJDAh (ORCPT ); Mon, 9 Nov 2015 22:00:37 -0500 X-AuditID: cbfee68e-f791c6d000001498-6b-56415dcc5ee9 From: Ingi Kim To: robh+dt@kernel.org, j.anaszewski@samsung.com Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Ingi Kim Subject: [PATCH] leds: ktd2692: Add missing of_node_put Date: Tue, 10 Nov 2015 12:00:24 +0900 Message-id: <1447124424-16525-1-git-send-email-ingi2.kim@samsung.com> X-Mailer: git-send-email 2.0.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrALMWRmVeSWpSXmKPExsWyRsSkUPdMrGOYwf/fHBY7bn5hs+i9+pzR 4vKuOWwWW9+sY7Ro3XuE3YHVY9OqTjaPvi2rGD0+b5ILYI7isklJzcksSy3St0vgylg5oZGl oJeronnqBZYGxikcXYycHBICJhI7X51kg7DFJC7cWw9kc3EICaxglNh94xQjTFHn5nNMEIlZ jBKnd/yFqprKJPFj+kywKjYBNYkbKxYygdgiAgYSrRt72UFsZoEEibNv1oDVCAuYS7xtOwgW ZxFQlXjVuRusnlfAVaJ/1yeobXISa16tYAFZICHwmE2ic+4DqAYBiW+TDwElOIASshKbDjBD 1EtKHFxxg2UCo+ACRoZVjKKpBckFxUnpRUZ6xYm5xaV56XrJ+bmbGIEBefrfs74djDcPWB9i FOBgVOLhnfDNIUyINbGsuDL3EKMp0IaJzFKiyfnAsM8riTc0NjOyMDUxNTYytzRTEudNkPoZ LCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoEx7If95Pm1u27yRbWfqJMMTTzw9O3O7Ng3BQ7G 6/u2soipxUzNF9dL3n9+1nUrk+OHBQUXJLzp7JOLWJ+8aYlaUXp/+c4rmzY+z9yTcjHS/urR oOn1Rqce2ajWLOBeeN6JjzfT5tzjkDt681rYnnRw+goLqB05O8umZPr2kNWPpBZ5ikZwJnsp sRRnJBpqMRcVJwIArWoDEEMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLLMWRmVeSWpSXmKPExsVy+t9jQd0zsY5hBlu7WCx23PzCZtF79Tmj xeVdc9gstr5Zx2jRuvcIuwOrx6ZVnWwefVtWMXp83iQXwBzVwGiTkZqYklqkkJqXnJ+SmZdu q+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RTSaEsMacUKBSQWFyspG+HaUJoiJuu BUxjhK5vSBBcj5EBGkhYw5ixckIjS0EvV0Xz1AssDYxTOLoYOTkkBEwkOjefY4KwxSQu3FvP 1sXIxSEkMItR4vSOv1DOVCaJH9NnMoJUsQmoSdxYsRCsQ0TAQKJ1Yy87iM0skCBx9s0asBph AXOJt20HweIsAqoSrzp3g9XzCrhK9O/6xAixTU5izasVLBMYuRcwMqxilEgtSC4oTkrPNcpL LdcrTswtLs1L10vOz93ECA76Z9I7GA/vcj/EKMDBqMTDO+GbQ5gQa2JZcWXuIUYJDmYlEV77 F0Ah3pTEyqrUovz4otKc1OJDjKZAB0xklhJNzgdGZF5JvKGxiZmRpZG5oYWRsbmSOK++p1GY kEB6YklqdmpqQWoRTB8TB6dUA+Oq67+E2I/Wu5ybdVrkjfIa3uly7vxX3y5TE/uj3qMu5f4t szHu/ZJN597s42LjaJ/4q+GjOFfhY56MpLXx09c1eSn0/v/YJWA8d/YGE9MN3QpzLL6e+6eY 3sC+W8LWb8I+34DmtVIPDvzJOONoxe6hPt1x6uuzjP5RwrsDLm8/7ihyYKnxh/1KLMUZiYZa zEXFiQBz4U81kAIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The refcount of device_node increases after of_node_get() is called. So, a break out of the loop requires of_node_put(). This patch adds missing of_node_put() when loop breaks. Signed-off-by: Ingi Kim --- drivers/leds/leds-ktd2692.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/leds/leds-ktd2692.c b/drivers/leds/leds-ktd2692.c index feca07b..dbf37ce 100644 --- a/drivers/leds/leds-ktd2692.c +++ b/drivers/leds/leds-ktd2692.c @@ -332,21 +332,26 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev, &cfg->movie_max_microamp); if (ret) { dev_err(dev, "failed to parse led-max-microamp\n"); - return ret; + goto err_parse_dt; } ret = of_property_read_u32(child_node, "flash-max-microamp", &cfg->flash_max_microamp); if (ret) { dev_err(dev, "failed to parse flash-max-microamp\n"); - return ret; + goto err_parse_dt; } ret = of_property_read_u32(child_node, "flash-max-timeout-us", &cfg->flash_max_timeout); - if (ret) + if (ret) { dev_err(dev, "failed to parse flash-max-timeout-us\n"); + goto err_parse_dt; + } + + return 0; +err_parse_dt: of_node_put(child_node); return ret; } -- 2.0.5