From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbbKJD1X (ORCPT ); Mon, 9 Nov 2015 22:27:23 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:45269 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893AbbKJD1S (ORCPT ); Mon, 9 Nov 2015 22:27:18 -0500 X-AuditID: cbfee690-f794e6d0000014de-19-5641641395e6 From: Vishnu Pratap Singh To: axboe@kernel.dk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, jmoyer@redhat.com, minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, davem@davemloft.net, neilb@suse.com, ulf.hansson@linaro.org, tiwai@suse.de, hare@suse.de, ming.lei@canonical.com, jarod@redhat.com, viro@zeniv.linux.org.uk, tj@kernel.org, adrian.hunter@intel.com, jonathanh@nvidia.com, grundler@chromium.org, linux-ide@vger.kernel.org Cc: cpgs@samsung.com, vishu13285@gmail.com, pintu.k@samsung.com, rohit.kr@samsung.com, Vishnu Pratap Singh Subject: [PATCH v2] block/floppy.c: handle blk_register_region() return value Date: Tue, 10 Nov 2015 08:55:50 +0530 Message-id: <1447125950-4279-1-git-send-email-vishnu.ps@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1446812535-10567-3-git-send-email-vishnu.ps@samsung.com> References: <1446812535-10567-3-git-send-email-vishnu.ps@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzVSfSyUcRz3e+655x63tKdD/dzKH6a13rzTr1Umq/ab1mYzWlrTxRMWx+7F NGWG5CXnkFbHltiKw3m7FUJcIiRkhJx2ZupKafJuqju3/vnu8/1+3v750hzBV1JIR4tlrEQs inGi+GS1nVfSUduI0yFuikpn1DtbTaGSWtOo0udRyKg7iEoG00n0rWuNQK1lBQR6cO8DQAMb oyRKV5WRqLtphkAjLSUUerq8wEMthlUeWqy/gurSVTykWH3NQ1/S7pBoRmmyGhvnCbTx7A1A PTUX0eBWDxfdV+gB0lYYuH4OWJWSS+HilGESaysnCNys0vNweauRwCMDctygzqLw1Fgrhd8+ 3CRxbtpPCi+0j1JYoVUDXKsdJXFjfxJuXmzk4t8NjoG7QvknI9iY6ARW4up7lR81NjHHi+/j Jz4er+ekAAOdDaxpyHjBIX0BYcG74dB0LZUN+LSAqQCw89c0+C8qq/9MWAgVgAMtpRzLkkpA Zf6rbTvFuMO64i6embBjdBxYNLW0reIw6QAW9WtMKpq2ZS7ANo3QbCCZ/bDnxQgwn22YMzBj PdnS5gh7uwu5ZmzNnIMfM9K2sYA5C2cnJ7bzITNPw5yCHzxLDgNXCnWkOQcy+2BDB8eS4wA7 K8ZJJbAtBVZqYM/Gh8dLr0VKvFykolipXBzpEh4X2wBMD9D/Z07ZBKY7TugAQwOnHTb5K34h Aq4oQXozVge8TQ35HKF9eJzpZ8SyMHdPHw/k7eXt6XHsuI/THpvvwvUgARMpkrE3WDaelYRJ 5DGsVAcI2lqYAlLDZOfVk5sOZdyNNQ02PM9+Z7Mkb6xRuPRoslJrc/qcb4decg8NdxsTHzm1 vNP1b1CmWrk+NVpN628Ffkr2He61lV3O2fvIKk/8Uh7jsJmp1QS3BfDX64yK8va7bGrAlKLq yYxrpf1yf/bydTv/rb5A45Jd72H/9/SBYENiYocTKY0SuR/iSKSif8Mw2Sr7AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKKsWRmVeSWpSXmKPExsVy+t9jQV3hFMcwg+VPpCxOPlnDZjFnPZBY fbefzeLlIU2LOedbWCxeHfnBZLFn0SQmi2k9lxgtzv66ymLRMmsRi8WxHY+YLC7vmsNmsezr e3aLXQ+/s1t82hhrsaFlFrtF3/fD7BbPm1tZLB5NAGp9ufkNk8Wv5UcZLY6vDbc4//c4q8WU vruMFltWPGR1kPSY1dDL5jG74SKLx5aVN5k8ds66y+6xeM9LJo/LZ0s9Nq3qZPO4c20Pm8eJ Gb9ZPHqb37F5vN93lc2jb8sqRo/1W66yeGw+Xe2x89NmVo/Pm+QCBKMaGG0yUhNTUosUUvOS 81My89JtlbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgGGipFCWmFMKFApILC5W0rfD NCE0xE3XAqYxQtc3JAiux8gADSSsYcy4dvMZe8Epror5NzYyNzA+5Ohi5OSQEDCRWLTxPhOE LSZx4d56ti5GLg4hgVmMEmd3LWCGcJqYJCZM3A9WxSZgKLFh9hF2kISIwCFmial3voBVMQu0 MEpMPb0OqIqDQ1jAV2LvOimQBhYBVYnj2y8zgoR5BVwk2n7WQWyTkzh5bDIriM0p4CZxva0Z zBYScJV4cusm+wRG3gWMDKsYJVILkguKk9JzDfNSy/WKE3OLS/PS9ZLzczcxgpPMM6kdjAd3 uR9iFOBgVOLhnfDNIUyINbGsuDL3EKMEB7OSCK/9C6AQb0piZVVqUX58UWlOavEhRlOguyYy S4km5wMTYF5JvKGxibmpsamliYWJmaWSOK++p1GYkEB6YklqdmpqQWoRTB8TB6dUA6PXux82 LfdldkYzb3l4u/nK6iveDZHnhI9XXsr1jN7vfqGD/+pV7aVsRzbdVz55f2dM9ETdW0u3sj/P tLBacn7yUnPdg1p7PZhrPrNoVM67Yntyfqv8r7ZAi9qbMaKr3Ni2PHizv3FZ/wKh2xayYV1l AnetH7rM3V50rmm/NZfyP4ET+S13Vn9XYinOSDTUYi4qTgQA4dSAEkgDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch handles blk_register_region() return value. Earlier blk_register_region() function doesn't handle error cases, now it is added, so the callers of this function should also handle it. Signed-off-by: Vishnu Pratap Singh --- - Verfied on X86 based ubuntu machine. - This patch depends on [PATCH 1/8] block/genhd.c: Add error handling - Changes v1 -> v2: - updated as per the Grant's review comment drivers/block/floppy.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index 331363e..459807c 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -4219,8 +4219,10 @@ static int __init do_floppy_init(void) if (err) goto out_unreg_blkdev; - blk_register_region(MKDEV(FLOPPY_MAJOR, 0), 256, THIS_MODULE, + err = blk_register_region(MKDEV(FLOPPY_MAJOR, 0), 256, THIS_MODULE, floppy_find, NULL, NULL); + if (err) + goto out_driver_unregister; for (i = 0; i < 256; i++) if (ITYPE(i)) @@ -4359,6 +4361,7 @@ out_release_dma: floppy_release_irq_and_dma(); out_unreg_region: blk_unregister_region(MKDEV(FLOPPY_MAJOR, 0), 256); +out_driver_unregister: platform_driver_unregister(&floppy_driver); out_unreg_blkdev: unregister_blkdev(FLOPPY_MAJOR, "fd"); -- 1.9.1