From: "Felipe F. Tonello" <eu@felipetonello.com>
To: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Robert Baldyga <r.baldyga@samsung.com>,
Clemens Ladisch <clemens@ladisch.de>
Subject: [PATCH v5 1/7] usb: gadget: f_midi: Transmit data only when IN ep is enabled
Date: Tue, 10 Nov 2015 17:52:03 +0000 [thread overview]
Message-ID: <1447177929-22252-2-git-send-email-eu@felipetonello.com> (raw)
In-Reply-To: <1447177929-22252-1-git-send-email-eu@felipetonello.com>
This makes sure f_midi doesn't try to enqueue data when the IN endpoint is
disabled, ie, USB cable is disconnected.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
drivers/usb/gadget/function/f_midi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index ce3c8a6..eeb989d 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -545,7 +545,7 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
}
}
- if (req->length > 0) {
+ if (req->length > 0 && ep->enabled) {
int err;
err = usb_ep_queue(ep, req, GFP_ATOMIC);
--
2.5.0
next prev parent reply other threads:[~2015-11-10 17:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 17:52 [PATCH v5 0/7] USB MIDI Gadget improvements and bug fixes Felipe F. Tonello
2015-11-10 17:52 ` Felipe F. Tonello [this message]
2015-11-13 8:08 ` [PATCH v5 1/7] usb: gadget: f_midi: Transmit data only when IN ep is enabled Robert Baldyga
2015-11-10 17:52 ` [PATCH v5 2/7] usb: gadget: f_midi: remove duplicated code Felipe F. Tonello
2015-11-13 8:09 ` Robert Baldyga
2015-11-10 17:52 ` [PATCH v5 3/7] usb: gadget: define free_ep_req as universal function Felipe F. Tonello
2015-11-13 8:11 ` Robert Baldyga
2015-11-10 17:52 ` [PATCH v5 4/7] usb: gadget: f_midi: fix leak on failed to enqueue out requests Felipe F. Tonello
2015-11-13 8:31 ` Robert Baldyga
2015-11-16 11:08 ` Felipe Ferreri Tonello
2015-11-16 11:43 ` Robert Baldyga
2015-11-25 13:02 ` Felipe Ferreri Tonello
2015-11-10 17:52 ` [PATCH v5 5/7] usb: gadget: gmidi: Cleanup legacy code Felipe F. Tonello
2015-11-13 8:34 ` Robert Baldyga
2015-11-10 17:52 ` [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface Felipe F. Tonello
2015-11-10 18:43 ` Sergei Shtylyov
2015-11-11 9:38 ` Felipe Ferreri Tonello
2015-11-11 18:02 ` Sergei Shtylyov
2015-11-13 8:11 ` Clemens Ladisch
2015-11-16 11:41 ` Felipe Ferreri Tonello
2015-11-13 8:14 ` Clemens Ladisch
2015-11-10 17:52 ` [PATCH v5 7/7] usb: gadget: f_midi: pre-allocate IN requests Felipe F. Tonello
2015-11-13 8:55 ` Clemens Ladisch
2015-11-25 17:22 ` Felipe Ferreri Tonello
2015-11-27 9:05 ` Clemens Ladisch
2015-11-27 18:03 ` Felipe Ferreri Tonello
2015-11-27 19:52 ` Clemens Ladisch
2015-11-13 12:38 ` Robert Baldyga
2015-11-25 16:54 ` Felipe Ferreri Tonello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447177929-22252-2-git-send-email-eu@felipetonello.com \
--to=eu@felipetonello.com \
--cc=balbi@ti.com \
--cc=clemens@ladisch.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®