From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751912AbbKJVrG (ORCPT ); Tue, 10 Nov 2015 16:47:06 -0500 Received: from ozlabs.org ([103.22.144.67]:50825 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285AbbKJVrE (ORCPT ); Tue, 10 Nov 2015 16:47:04 -0500 Message-ID: <1447192023.25407.0.camel@ellerman.id.au> Subject: Re: [PATCH] of: Print rather than WARN'ing when overlap check fails From: Michael Ellerman To: David Laight , "robh+dt@kernel.org" Cc: "devicetree@vger.kernel.org" , "frowand.list@gmail.com" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@ozlabs.org" , "grant.likely@linaro.org" , "mitchelh@codeaurora.org" Date: Wed, 11 Nov 2015 08:47:03 +1100 In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CBCEE2E@AcuExch.aculab.com> References: <1447132113-31434-1-git-send-email-mpe@ellerman.id.au> <063D6719AE5E284EB5DD2968C1650D6D1CBCEE2E@AcuExch.aculab.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-11-10 at 09:41 +0000, David Laight wrote: > From: Michael Ellerman > > Sent: 10 November 2015 05:09 > > __rmem_check_for_overlap() is called very early in boot, and on some > > powerpc systems it's not safe to call WARN that early in boot. > > > > If the overlap check fails the system will oops instead of printing a > > warning. Furthermore because it's so early in boot the console is not up > > and the user doesn't see the oops, they just get a dead system. > > Wouldn't it be better to add the required checks to WARN()? Yes obviously it would. But that's less simple than it sounds. I'm working on it. cheers