mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: gregkh@linuxfoundation.org, a.p.zijlstra@chello.nl,
	alexander.shishkin@linux.intel.com, acme@kernel.org,
	mingo@redhat.com, corbet@lwn.net, nicolas.pitre@linaro.org
Cc: adrian.hunter@intel.com, zhang.chunyan@linaro.org,
	mike.leach@arm.com, tor@ti.com, al.grant@arm.com,
	pawel.moll@arm.com, fainelli@broadcom.com,
	linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org
Subject: [PATCH V3 13/26] coresight: etm3x: implementing user/kernel mode tracing
Date: Wed, 11 Nov 2015 15:18:03 -0700	[thread overview]
Message-ID: <1447280296-19147-14-git-send-email-mathieu.poirier@linaro.org> (raw)
In-Reply-To: <1447280296-19147-1-git-send-email-mathieu.poirier@linaro.org>

Adding new mode to limit tracing to kernel or user space.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
 drivers/hwtracing/coresight/coresight-etm.h        |  7 ++-
 .../hwtracing/coresight/coresight-etm3x-sysfs.c    |  4 ++
 drivers/hwtracing/coresight/coresight-etm3x.c      | 63 ++++++++++++++++++++++
 drivers/hwtracing/coresight/coresight-priv.h       |  3 ++
 4 files changed, 76 insertions(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-etm.h b/drivers/hwtracing/coresight/coresight-etm.h
index f01862fc98dd..e72815073b63 100644
--- a/drivers/hwtracing/coresight/coresight-etm.h
+++ b/drivers/hwtracing/coresight/coresight-etm.h
@@ -110,7 +110,10 @@
 #define ETM_MODE_STALL		BIT(2)
 #define ETM_MODE_TIMESTAMP	BIT(3)
 #define ETM_MODE_CTXID		BIT(4)
-#define ETM_MODE_ALL		0x1f
+#define ETM_MODE_ALL		(ETM_MODE_EXCLUDE | ETM_MODE_CYCACC | \
+				 ETM_MODE_STALL | ETM_MODE_TIMESTAMP | \
+				 ETM_MODE_CTXID | ETM_MODE_EXCL_KERN | \
+				 ETM_MODE_EXCL_USER)
 
 #define ETM_SQR_MASK		0x3
 #define ETM_TRACEID_MASK	0x3f
@@ -296,5 +299,7 @@ static inline unsigned int etm_readl(struct etm_drvdata *drvdata, u32 off)
 extern const struct attribute_group *coresight_etm_groups[];
 int etm_get_trace_id(struct etm_drvdata *drvdata);
 void etm_set_default(struct etm_config *config);
+void etm_config_trace_mode(struct etm_drvdata *drvdata,
+			   struct etm_config *config, u32 mode);
 struct etm_config *get_etm_config(struct etm_drvdata *drvdata);
 #endif
diff --git a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c
index 6da50d94ec6f..f7318f04118d 100644
--- a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c
+++ b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c
@@ -176,6 +176,10 @@ static ssize_t mode_store(struct device *dev,
 		config->ctrl |= ETMCR_CTXID_SIZE;
 	else
 		config->ctrl &= ~ETMCR_CTXID_SIZE;
+
+	if (config->mode & (ETM_MODE_EXCL_KERN | ETM_MODE_EXCL_USER))
+		etm_config_trace_mode(drvdata, config, config->mode);
+
 	spin_unlock(&drvdata->spinlock);
 
 	return size;
diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c
index e973e4d13bcb..a83c67d13b21 100644
--- a/drivers/hwtracing/coresight/coresight-etm3x.c
+++ b/drivers/hwtracing/coresight/coresight-etm3x.c
@@ -252,6 +252,69 @@ void etm_set_default(struct etm_config *config)
 	config->ctxid_mask = 0x0;
 }
 
+void etm_config_trace_mode(struct etm_drvdata *drvdata,
+			   struct etm_config *config,
+			   u32 mode)
+{
+	u32 flags;
+
+	mode &= (ETM_MODE_EXCL_KERN | ETM_MODE_EXCL_USER);
+
+	/* excluding kernel AND user space doesn't make sense */
+	if (mode == (ETM_MODE_EXCL_KERN | ETM_MODE_EXCL_USER))
+		return;
+
+	/* nothing to do if neither flags are set */
+	if (!(mode & ETM_MODE_EXCL_KERN) && !(mode & ETM_MODE_EXCL_USER))
+		return;
+
+	flags = (1 << 0 |	/* instruction execute */
+		 3 << 3 |	/* ARM instruction */
+		 0 << 5 |	/* No data value comparison */
+		 0 << 7 |	/* No exact mach */
+		 0 << 8);	/* Ignore context ID */
+
+	/* No need to worry about single address comparators. */
+	config->enable_ctrl2 = 0x0;
+
+	/* Bit 0 is address range comparator 1 */
+	config->enable_ctrl1 = ETMTECR1_ADDR_COMP_1;
+
+	/*
+	 * On ETMv3.5:
+	 * ETMACTRn[13,11] == Non-secure state comparison control
+	 * ETMACTRn[12,10] == Secure state comparison control
+	 *
+	 * b00 == Match in all modes in this state
+	 * b01 == Do not match in any more in this state
+	 * b10 == Match in all modes excepts user mode in this state
+	 * b11 == Match only in user mode in this state
+	 */
+
+	/* Tracing in secure mode is not supported at this time */
+	flags |= (0 << 12 | 1 << 10);
+
+	if (mode & ETM_MODE_EXCL_USER) {
+		/* exclude user, match all modes except user mode */
+		flags |= (1 << 13 | 0 << 11);
+	} else {
+		/* exclude kernel, match only in user mode */
+		flags |= (1 << 13 | 1 << 11);
+	}
+
+	/*
+	 * The ETMEEVR register is already set to "hard wire A".  As such
+	 * all there is to do is setup an address comparator that spans
+	 * the entire address range and configure the state and mode bits.
+	 */
+	config->addr_val[0] = (u32) 0x0;
+	config->addr_val[1] = (u32) ~0x0;
+	config->addr_acctype[0] = flags;
+	config->addr_acctype[1] = flags;
+	config->addr_type[0] = ETM_ADDR_TYPE_RANGE;
+	config->addr_type[1] = ETM_ADDR_TYPE_RANGE;
+}
+
 static void etm_enable_hw(void *info)
 {
 	int i;
diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h
index ed116b303e87..932f34a84d96 100644
--- a/drivers/hwtracing/coresight/coresight-priv.h
+++ b/drivers/hwtracing/coresight/coresight-priv.h
@@ -34,6 +34,9 @@
 #define TIMEOUT_US		100
 #define BMVAL(val, lsb, msb)	((val & GENMASK(msb, lsb)) >> lsb)
 
+#define ETM_MODE_EXCL_KERN	BIT(30)
+#define ETM_MODE_EXCL_USER	BIT(31)
+
 enum cs_mode {
 	CS_MODE_DISABLED,
 	CS_MODE_SYSFS,
-- 
1.9.1


  parent reply	other threads:[~2015-11-11 22:19 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 22:17 [PATCH V3 00/26] Coresight integration with perf Mathieu Poirier
2015-11-11 22:17 ` [PATCH V3 01/26] coresight: etm3x: moving etm_readl/writel to header file Mathieu Poirier
2015-11-11 22:17 ` [PATCH V3 02/26] coresight: etm3x: moving sysFS entries to dedicated file Mathieu Poirier
2015-11-11 22:30   ` Arnd Bergmann
2015-11-13 16:17     ` Mathieu Poirier
2015-11-13 16:26       ` Arnd Bergmann
2015-11-11 22:17 ` [PATCH V3 03/26] coresight: etm3x: unlocking tracers in default arch init Mathieu Poirier
2015-11-11 22:17 ` [PATCH V3 04/26] coresight: etm3x: splitting struct etm_drvdata Mathieu Poirier
2015-11-11 22:17 ` [PATCH V3 05/26] coresight: etm3x: implementing 'cpu_id()' API Mathieu Poirier
2015-11-11 22:17 ` [PATCH V3 06/26] coresight: associating path with session rather than tracer Mathieu Poirier
2015-11-11 22:17 ` [PATCH V3 07/26] coresight: moving PM runtime operations to core framework Mathieu Poirier
2015-11-11 22:17 ` [PATCH V3 08/26] coresight: etm3x: adding operation mode for etm_enable() Mathieu Poirier
2015-11-11 22:17 ` [PATCH V3 09/26] coresight: add API to get sink from path Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 10/26] coresight: etm3x: set progbit to stop trace collection Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 11/26] coresight: etm3x: changing default trace configuration Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 12/26] coresight: etm3x: consolidating initial config Mathieu Poirier
2015-11-11 22:18 ` Mathieu Poirier [this message]
2015-11-11 22:18 ` [PATCH V3 14/26] coresight: etm3x: adding perf_get/set_config() API Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 15/26] coresight: etm3x: implementing perf_enable/disable() API Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 16/26] perf: changing pmu::setup_aux() parameter to include event Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 17/26] coresight: etb10: moving to local atomic operations Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 18/26] coresight: adding operation mode for sink->enable() Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 19/26] coresight: etb10: implementing AUX space API Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 20/26] coresight: etm-perf: new PMU driver for ETM tracers Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 21/26] coresight: introducing a global trace ID function Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 22/26] coresight: updating documentation to reflect integration with perf Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 23/26] perf tools: making function set_max_cpu_num() non static Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 24/26] perf tools: adding perf_session to *info_prive_size() Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 25/26] perf tools: making coresight PMU listable Mathieu Poirier
2015-11-11 22:18 ` [PATCH V3 26/26] perf tools: adding coresight etm PMU record capabilities Mathieu Poirier
2015-11-12 10:53 ` [PATCH V3 00/26] Coresight integration with perf Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447280296-19147-14-git-send-email-mathieu.poirier@linaro.org \
    --to=mathieu.poirier@linaro.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=al.grant@arm.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=fainelli@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.leach@arm.com \
    --cc=mingo@redhat.com \
    --cc=nicolas.pitre@linaro.org \
    --cc=pawel.moll@arm.com \
    --cc=tor@ti.com \
    --cc=zhang.chunyan@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®