From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753089AbbKLCUF (ORCPT ); Wed, 11 Nov 2015 21:20:05 -0500 Received: from ozlabs.org ([103.22.144.67]:33339 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753040AbbKLCUC (ORCPT ); Wed, 11 Nov 2015 21:20:02 -0500 Message-ID: <1447294799.29472.15.camel@ellerman.id.au> Subject: Re: [PATCH v2] of: Check for overlap in reserved memory regions From: Michael Ellerman To: Mitchel Humpherys , Rob Herring , Frank Rowand , Grant Likely , devicetree@vger.kernel.org, Marek Szyprowski Cc: linux-kernel@vger.kernel.org Date: Thu, 12 Nov 2015 13:19:59 +1100 In-Reply-To: <1442367036-15205-1-git-send-email-mitchelh@codeaurora.org> References: <1442367036-15205-1-git-send-email-mitchelh@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-09-15 at 18:30 -0700, Mitchel Humpherys wrote: > Any overlap in the reserved memory regions (those specified in the > reserved-memory DT node) is a bug. Can you expand a bit on why you think it's a bug? I assume it was discussed at some point on the list but I didn't see it sorry. There's nothing I can see in the binding document[1] about whether regions can overlap, or what it would mean if they did. If we want to declare that overlapping regions are always a bug then there should be some text in the binding explaining that. There's also the possibility that we have existing device trees in the wild that contain overlapping regions, and whether we think it's OK to retrospectively declare that they're incorrect. cheers [1]: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt