From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
tgraf@suug.ch, Tom Herbert <tom@herbertland.com>,
Jiri Benc <jbenc@redhat.com>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Subject: Re: [PATCH] ip_tunnel: disable preemption when updating per-cpu tstats
Date: Thu, 12 Nov 2015 17:25:09 +0100 [thread overview]
Message-ID: <1447345509.2333208.438003833.012C1A95@webmail.messagingengine.com> (raw)
In-Reply-To: <1447342212-5543-1-git-send-email-Jason@zx2c4.com>
On Thu, Nov 12, 2015, at 16:30, Jason A. Donenfeld wrote:
> if (err > 0) {
> - struct pcpu_sw_netstats *tstats = this_cpu_ptr(stats);
> -
> + struct pcpu_sw_netstats *tstats;
> + preempt_disable();
> + tstats = this_cpu_ptr(stats);
The canonical way is get_cpu_ptr(stats) / put_cpu_ptr.
Bye,
Hannes
next prev parent reply other threads:[~2015-11-12 16:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 15:30 Jason A. Donenfeld
2015-11-12 16:25 ` Hannes Frederic Sowa [this message]
2015-11-12 16:36 ` Jason A. Donenfeld
2015-11-12 16:52 ` Jason A. Donenfeld
2015-11-12 16:35 ` [PATCH v2] " Jason A. Donenfeld
2015-11-16 10:04 ` Hannes Frederic Sowa
2015-11-16 19:17 ` David Miller
2015-11-16 19:33 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447345509.2333208.438003833.012C1A95@webmail.messagingengine.com \
--to=hannes@stressinduktion.org \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®