mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luis Henriques <luis.henriques@canonical.com>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	kernel-team@lists.ubuntu.com
Cc: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Luis Henriques <luis.henriques@canonical.com>
Subject: [PATCH 3.16.y-ckt 58/94] powerpc/rtas: Validate rtas.entry before calling enter_rtas()
Date: Fri, 13 Nov 2015 10:09:52 +0000	[thread overview]
Message-ID: <1447409428-12178-59-git-send-email-luis.henriques@canonical.com> (raw)
In-Reply-To: <1447409428-12178-1-git-send-email-luis.henriques@canonical.com>

3.16.7-ckt20 -stable review patch.  If anyone has any objections, please let me know.

------------------

From: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

commit 8832317f662c06f5c06e638f57bfe89a71c9b266 upstream.

Currently we do not validate rtas.entry before calling enter_rtas(). This
leads to a kernel oops when user space calls rtas system call on a powernv
platform (see below). This patch adds code to validate rtas.entry before
making enter_rtas() call.

  Oops: Exception in kernel mode, sig: 4 [#1]
  SMP NR_CPUS=1024 NUMA PowerNV
  task: c000000004294b80 ti: c0000007e1a78000 task.ti: c0000007e1a78000
  NIP: 0000000000000000 LR: 0000000000009c14 CTR: c000000000423140
  REGS: c0000007e1a7b920 TRAP: 0e40   Not tainted  (3.18.17-340.el7_1.pkvm3_1_0.2400.1.ppc64le)
  MSR: 1000000000081000 <HV,ME>  CR: 00000000  XER: 00000000
  CFAR: c000000000009c0c SOFTE: 0
  NIP [0000000000000000]           (null)
  LR [0000000000009c14] 0x9c14
  Call Trace:
  [c0000007e1a7bba0] [c00000000041a7f4] avc_has_perm_noaudit+0x54/0x110 (unreliable)
  [c0000007e1a7bd80] [c00000000002ddc0] ppc_rtas+0x150/0x2d0
  [c0000007e1a7be30] [c000000000009358] syscall_exit+0x0/0x98

Fixes: 55190f88789a ("powerpc: Add skeleton PowerNV platform")
Reported-by: NAGESWARA R. SASTRY <nasastry@in.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
[mpe: Reword change log, trim oops, and add stable + fixes]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
---
 arch/powerpc/kernel/rtas.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/powerpc/kernel/rtas.c b/arch/powerpc/kernel/rtas.c
index af0dafab5807..79c459a2b684 100644
--- a/arch/powerpc/kernel/rtas.c
+++ b/arch/powerpc/kernel/rtas.c
@@ -1045,6 +1045,9 @@ asmlinkage int ppc_rtas(struct rtas_args __user *uargs)
 	if (!capable(CAP_SYS_ADMIN))
 		return -EPERM;
 
+	if (!rtas.entry)
+		return -EINVAL;
+
 	if (copy_from_user(&args, uargs, 3 * sizeof(u32)) != 0)
 		return -EFAULT;
 

  parent reply	other threads:[~2015-11-13 10:12 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 10:08 [3.16.y-ckt stable] Linux 3.16.7-ckt20 stable review Luis Henriques
2015-11-13 10:08 ` [PATCH 3.16.y-ckt 01/94] regmap: debugfs: Ensure we don't underflow when printing access masks Luis Henriques
2015-11-13 10:08 ` [PATCH 3.16.y-ckt 02/94] regmap: debugfs: Don't bother actually printing when calculating max length Luis Henriques
2015-11-13 10:08 ` [PATCH 3.16.y-ckt 03/94] x86/xen: Support kexec/kdump in HVM guests by doing a soft reset Luis Henriques
2015-11-13 10:08 ` [PATCH 3.16.y-ckt 04/94] s390/boot/decompression: disable floating point in decompressor Luis Henriques
2015-11-13 10:08 ` [PATCH 3.16.y-ckt 05/94] svcrdma: handle rdma read with a non-zero initial page offset Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 06/94] dm: fix AB-BA deadlock in __dm_destroy() Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 07/94] [SMB3] Do not fall back to SMBWriteX in set_file_size error cases Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 08/94] clk: ti: fix dual-registration of uart4_ick Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 09/94] ASoC: dwc: correct irq clear method Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 10/94] dm raid: fix round up of default region size Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 11/94] ALSA: hda: Add dock support for ThinkPad T550 Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 12/94] ALSA: hda - Apply SPDIF pin ctl to MacBookPro 12,1 Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 13/94] USB: Add reset-resume quirk for two Plantronics usb headphones Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 14/94] usb: Add device quirk for Logitech PTZ cameras Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 15/94] staging: speakup: fix speakup-r regression Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 16/94] ALSA: synth: Fix conflicting OSS device registration on AWE32 Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 17/94] arm64: readahead: fault retry breaks mmap file read random detection Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 18/94] sched/core: Fix TASK_DEAD race in finish_task_switch() Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 19/94] dm cache: fix NULL pointer when switching from cleaner policy Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 20/94] 3w-9xxx: don't unmap bounce buffered commands Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 21/94] workqueue: make sure delayed work run in local cpu Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 22/94] drm/radeon: add pm sysfs files late Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 23/94] drm/radeon: add quirk for MSI R7 370 Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 24/94] drm/radeon: add quirk for ASUS " Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 25/94] crypto: sparc - initialize blkcipher.ivsize Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 26/94] drm/nouveau/fbcon: take runpm reference when userspace has an open fd Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 27/94] arm64: errata: use KBUILD_CFLAGS_MODULE for erratum #843419 Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 28/94] crypto: ahash - ensure statesize is non-zero Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 29/94] dm thin: fix missing pool reference count decrement in pool_ctr error path Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 30/94] btrfs: check unsupported filters in balance arguments Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 31/94] btrfs: fix use after free iterating extrefs Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 32/94] i2c: rcar: enable RuntimePM before registering to the core Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 33/94] i2c: s3c2410: " Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 34/94] i2c: designware-platdrv: " Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 35/94] i2c: designware: Do not use parameters from ACPI on Dell Inspiron 7348 Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 36/94] btrfs: fix possible leak in btrfs_ioctl_balance() Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 37/94] drm: Reject DRI1 hw lock ioctl functions for kms drivers Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 38/94] usb: xhci: Add support for URB_ZERO_PACKET to bulk/sg transfers Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 39/94] rbd: fix double free on rbd_dev->header_name Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 40/94] ath9k: declare required extra tx headroom Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 41/94] iio: accel: sca3000: memory corruption in sca3000_read_first_n_hw_rb() Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 42/94] iwlwifi: dvm: fix D3 firmware PN programming Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 43/94] iwlwifi: mvm: " Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 44/94] iwlwifi: fix firmware filename for 3160 Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 45/94] iwlwifi: pci: add a few more PCI subvendor IDs for the 7265 series Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 46/94] ARM: orion: Fix DSA platform device after mvmdio conversion Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 47/94] xen-blkfront: check for null drvdata in blkback_changed (XenbusStateClosing) Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 48/94] iio: mxs-lradc: Fix temperature offset Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 49/94] ALSA: hda - Fix inverted internal mic on Lenovo G50-80 Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 50/94] drm/i915: Deny wrapping an userptr into a framebuffer Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 51/94] x86/efi: Fix multiple GOP device support Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 52/94] ASoC: Add info callback for SX_TLV controls Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 53/94] xhci: don't finish a TD if we get a short transfer event mid TD Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 54/94] xhci: handle no ping response error properly Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 55/94] xhci: Add spurious wakeup quirk for LynxPoint-LP controllers Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 56/94] ASoC: wm8904: Correct number of EQ registers Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 57/94] drm/nouveau/gem: return only valid domain when there's only one Luis Henriques
2015-11-13 10:09 ` Luis Henriques [this message]
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 59/94] mm: make sendfile(2) killable Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 60/94] rbd: don't leak parent_spec in rbd_dev_probe_parent() Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 61/94] rbd: prevent kernel stack blow up on rbd map Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 62/94] dm btree remove: fix a bug when rebalancing nodes after removal Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 63/94] dm btree: fix leak of bufio-backed block in btree_split_beneath error path Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 64/94] IB/cm: Fix rb-tree duplicate free and use-after-free Luis Henriques
2015-11-13 10:09 ` [PATCH 3.16.y-ckt 65/94] iwlwifi: mvm: init card correctly on ctkill exit check Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 66/94] module: Fix locking in symbol_put_addr() Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 67/94] crypto: api - Only abort operations on fatal signal Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 68/94] md/raid1: submit_bio_wait() returns 0 on success Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 69/94] md/raid10: " Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 70/94] iommu/amd: Don't clear DTE flags when modifying it Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 71/94] i2c: mv64xxx: really allow I2C offloading Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 72/94] drm/radeon: don't try to recreate sysfs entries on resume Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 73/94] mvsas: Fix NULL pointer dereference in mvs_slot_task_free Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 74/94] Revert "ARM64: unwind: Fix PC calculation" Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 75/94] drm/radeon: Restore LCD backlight level on resume (>= R5xx) Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 76/94] drm/radeon: move bl encoder assignment into bl init Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 77/94] drm/radeon: fix dpms when driver backlight control is disabled Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 78/94] rbd: require stable pages if message data CRCs are enabled Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 79/94] md/raid5: fix locking in handle_stripe_clean_event() Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 80/94] Revert "md: allow a partially recovered device to be hot-added to an array." Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 81/94] ipv6: Fix IPsec pre-encap fragmentation check Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 82/94] ppp: fix pppoe_dev deletion condition in pppoe_release() Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 83/94] ipv6: gre: support SIT encapsulation Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 84/94] net/mlx4: Copy/set only sizeof struct mlx4_eqe bytes Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 85/94] serial: 8250_pci: Add support for 16 port Exar boards Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 86/94] serial: 8250_pci: Add support for 12 " Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 87/94] serial: 8250_pci: Correct uartclk for xr17v35x expansion chips Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 88/94] isdn_ppp: Add checks for allocation failure in isdn_ppp_open() Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 89/94] ppp, slip: Validate VJ compression slot parameters completely Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 90/94] staging/dgnc: fix info leak in ioctl Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 91/94] power: bq24190_charger: suppress build warning Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 92/94] sfc: Fix memcpy() with const destination compiler warning Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 93/94] sched/preempt: Rename PREEMPT_CHECK_OFFSET to PREEMPT_DISABLE_OFFSET Luis Henriques
2015-11-13 10:10 ` [PATCH 3.16.y-ckt 94/94] sched/preempt: Fix cond_resched_lock() and cond_resched_softirq() Luis Henriques
2015-11-16 17:56 ` [3.16.y-ckt stable] Linux 3.16.7-ckt20 stable review Ben Hutchings
2015-11-16 21:55   ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447409428-12178-59-git-send-email-luis.henriques@canonical.com \
    --to=luis.henriques@canonical.com \
    --cc=hegdevasant@linux.vnet.ibm.com \
    --cc=kernel-team@lists.ubuntu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®