From: Nizam Haider <nizamhaider786@gmail.com>
To: lidza.louina@gmail.com
Cc: markh@compro.net, driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Nizam Haider <nizamhaider786@gmail.com>,
Nizam Haider <nijamh@cdac.in>
Subject: [PATCH 1/2] Staging: dgnc: dgnc_neo.c: usleep_range is preferred over udelay
Date: Fri, 13 Nov 2015 16:48:10 +0530 [thread overview]
Message-ID: <1447413491-17055-1-git-send-email-nizamhaider786@gmail.com> (raw)
removed heckpatch warning
Signed-off-by: Nizam Haider <nijamh@cdac.in>
---
drivers/staging/dgnc/dgnc_neo.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index 8106f52..cf5bfc7 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
+++ b/drivers/staging/dgnc/dgnc_neo.c
@@ -1335,7 +1335,7 @@ static void neo_flush_uart_write(struct channel_t *ch)
/* Check to see if the UART feels it completely flushed the FIFO. */
tmp = readb(&ch->ch_neo_uart->isr_fcr);
if (tmp & 4)
- udelay(10);
+ usleep_range(10, 50);
else
break;
}
@@ -1363,7 +1363,7 @@ static void neo_flush_uart_read(struct channel_t *ch)
/* Check to see if the UART feels it completely flushed the FIFO. */
tmp = readb(&ch->ch_neo_uart->isr_fcr);
if (tmp & 2)
- udelay(10);
+ usleep_range(10, 50);
else
break;
}
@@ -1588,7 +1588,7 @@ static void neo_assert_modem_signals(struct channel_t *ch)
neo_pci_posting_flush(ch->ch_bd);
/* Give time for the UART to actually raise/drop the signals */
- udelay(10);
+ usleep_range(10, 50);
}
static void neo_send_start_character(struct channel_t *ch)
@@ -1600,7 +1600,7 @@ static void neo_send_start_character(struct channel_t *ch)
ch->ch_xon_sends++;
writeb(ch->ch_startc, &ch->ch_neo_uart->txrx);
neo_pci_posting_flush(ch->ch_bd);
- udelay(10);
+ usleep_range(10, 50);
}
}
@@ -1613,7 +1613,7 @@ static void neo_send_stop_character(struct channel_t *ch)
ch->ch_xoff_sends++;
writeb(ch->ch_stopc, &ch->ch_neo_uart->txrx);
neo_pci_posting_flush(ch->ch_bd);
- udelay(10);
+ usleep_range(10, 50);
}
}
--
1.8.1.4
next reply other threads:[~2015-11-13 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 11:18 Nizam Haider [this message]
2015-11-13 11:18 ` [PATCH 2/2] Staging: dgnc: dgnc_neo.c: checkpatch cleanup Nizam Haider
2015-11-13 12:47 ` Sudip Mukherjee
2015-12-14 19:15 ` [PATCH 1/2] Staging: dgnc: dgnc_neo.c: usleep_range is preferred over udelay Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447413491-17055-1-git-send-email-nizamhaider786@gmail.com \
--to=nizamhaider786@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
--cc=nijamh@cdac.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®