mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: linux-rdma@vger.kernel.org
Cc: sagig@dev.mellanox.co.il, bart.vanassche@sandisk.com,
	axboe@fb.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/9] IB: add a helper to safely drain a QP
Date: Fri, 13 Nov 2015 14:46:44 +0100	[thread overview]
Message-ID: <1447422410-20891-4-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1447422410-20891-1-git-send-email-hch@lst.de>

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/infiniband/core/cq.c | 46 ++++++++++++++++++++++++++++++++++++++++++++
 include/rdma/ib_verbs.h      |  2 ++
 2 files changed, 48 insertions(+)

diff --git a/drivers/infiniband/core/cq.c b/drivers/infiniband/core/cq.c
index d9eb796..bf2a079 100644
--- a/drivers/infiniband/core/cq.c
+++ b/drivers/infiniband/core/cq.c
@@ -206,3 +206,49 @@ void ib_free_cq(struct ib_cq *cq)
 	WARN_ON_ONCE(ret);
 }
 EXPORT_SYMBOL(ib_free_cq);
+
+struct ib_stop_cqe {
+	struct ib_cqe	cqe;
+	struct completion done;
+};
+
+static void ib_stop_done(struct ib_cq *cq, struct ib_wc *wc)
+{
+	struct ib_stop_cqe *stop =
+		container_of(wc->wr_cqe, struct ib_stop_cqe, cqe);
+
+	complete(&stop->done);
+}
+
+/*
+ * Change a queue pair into the error state and wait until all receive
+ * completions have been processed before destroying it. This avoids that
+ * the receive completion handler can access the queue pair while it is
+ * being destroyed.
+ */
+void ib_drain_qp(struct ib_qp *qp)
+{
+	struct ib_qp_attr attr = { .qp_state = IB_QPS_ERR };
+	struct ib_stop_cqe stop = { };
+	struct ib_recv_wr wr, *bad_wr;
+	int ret;
+
+	wr.wr_cqe = &stop.cqe;
+	stop.cqe.done = ib_stop_done;
+	init_completion(&stop.done);
+
+	ret = ib_modify_qp(qp, &attr, IB_QP_STATE);
+	if (ret) {
+		WARN_ONCE(ret, "failed to drain QP: %d\n", ret);
+		return;
+	}
+
+	ret = ib_post_recv(qp, &wr, &bad_wr);
+	if (ret) {
+		WARN_ONCE(ret, "failed to drain QP: %d\n", ret);
+		return;
+	}
+
+	wait_for_completion(&stop.done);
+}
+EXPORT_SYMBOL(ib_drain_qp);
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index e11e038..f59a8d3 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -3075,4 +3075,6 @@ int ib_sg_to_pages(struct ib_mr *mr,
 		   int sg_nents,
 		   int (*set_page)(struct ib_mr *, u64));
 
+void ib_drain_qp(struct ib_qp *qp);
+
 #endif /* IB_VERBS_H */
-- 
1.9.1


  parent reply	other threads:[~2015-11-13 13:54 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 13:46 add a proper completion queue abstraction Christoph Hellwig
2015-11-13 13:46 ` [PATCH 1/9] move blk_iopoll to limit and make it generally available Christoph Hellwig
2015-11-13 15:23   ` Or Gerlitz
2015-11-14  7:02     ` Christoph Hellwig
2015-11-15  8:48       ` Sagi Grimberg
2015-11-15  9:04         ` Or Gerlitz
2015-11-15 13:16           ` Sagi Grimberg
2015-11-15 12:51         ` Christoph Hellwig
2015-11-13 19:19   ` Bart Van Assche
2015-11-14  7:02     ` Christoph Hellwig
2015-11-17 17:16       ` Bart Van Assche
2015-11-17 17:27         ` Bart Van Assche
2015-11-18 13:58         ` Christoph Hellwig
2015-11-13 13:46 ` [PATCH 2/9] IB: add a proper completion queue abstraction Christoph Hellwig
2015-11-13 18:25   ` Jason Gunthorpe
2015-11-13 19:57     ` Bart Van Assche
2015-11-13 22:06       ` Jason Gunthorpe
2015-11-14  7:13         ` Christoph Hellwig
2015-11-23 20:37           ` Jason Gunthorpe
2015-11-23 21:04             ` Bart Van Assche
2015-11-23 21:28               ` Jason Gunthorpe
2015-11-23 21:54                 ` Bart Van Assche
2015-11-23 22:18                   ` Jason Gunthorpe
2015-11-23 22:33                     ` Bart Van Assche
2015-11-23 23:06                       ` Jason Gunthorpe
     [not found]                         ` <B24F4DDE-709A-4D2D-8B26-4E83325DBB1A@asomi.com>
2015-11-24  0:00                           ` Jason Gunthorpe
2015-11-24  0:34                             ` Tom Talpey
2015-11-24  0:40                               ` Jason Gunthorpe
2015-11-24  2:35                             ` Caitlin Bestler
2015-11-24  7:03                               ` Jason Gunthorpe
2015-11-24 12:52                                 ` Tom Talpey
2015-11-14  7:08     ` Christoph Hellwig
2015-11-23 20:01       ` Jason Gunthorpe
2015-11-23 20:57         ` Christoph Hellwig
2015-11-15  9:40   ` Sagi Grimberg
2015-11-15 12:55     ` Christoph Hellwig
2015-11-15 13:21       ` Sagi Grimberg
2015-11-17 17:52   ` Bart Van Assche
2015-11-18  7:55     ` Sagi Grimberg
2015-11-18 18:20       ` Bart Van Assche
2015-11-20 10:16         ` Christoph Hellwig
2015-11-20 16:50           ` Bart Van Assche
2015-11-22  9:51             ` Sagi Grimberg
2015-11-22 10:13               ` Christoph Hellwig
2015-11-22 10:36                 ` Sagi Grimberg
2015-11-22 13:23                   ` Christoph Hellwig
2015-11-22 14:57                     ` Sagi Grimberg
2015-11-22 16:55                       ` Bart Van Assche
2015-11-18 14:00     ` Christoph Hellwig
2015-11-13 13:46 ` Christoph Hellwig [this message]
2015-11-13 16:16   ` [PATCH 3/9] IB: add a helper to safely drain a QP Steve Wise
2015-11-14  7:05     ` Christoph Hellwig
2015-11-15  9:34   ` Sagi Grimberg
2015-11-16 16:38     ` Steve Wise
2015-11-16 18:30       ` Steve Wise
2015-11-16 18:37         ` Sagi Grimberg
2015-11-16 19:03           ` Steve Wise
2015-11-17  8:54             ` Sagi Grimberg
2015-11-23 10:28             ` Sagi Grimberg
2015-11-23 10:35               ` Sagi Grimberg
2015-11-23 14:33                 ` 'Christoph Hellwig'
2015-11-23 14:48                 ` Steve Wise
2015-11-23 14:44               ` Steve Wise
2015-11-17 17:06     ` Bart Van Assche
2015-11-18  7:59       ` Sagi Grimberg
2015-11-18 11:32   ` Sagi Grimberg
2015-11-18 14:06     ` Christoph Hellwig
2015-11-18 15:21       ` Steve Wise
2015-11-13 13:46 ` [PATCH 4/9] srpt: chain RDMA READ/WRITE requests Christoph Hellwig
2015-11-18  1:17   ` Bart Van Assche
2015-11-18  9:15     ` Sagi Grimberg
2015-11-18 16:32       ` Bart Van Assche
2015-11-20 10:20         ` Christoph Hellwig
2015-11-18 14:06     ` Christoph Hellwig
2015-11-13 13:46 ` [PATCH 5/9] srpt: use the new CQ API Christoph Hellwig
2015-11-17 18:22   ` Bart Van Assche
2015-11-17 19:38   ` Bart Van Assche
2015-11-18 14:03     ` Christoph Hellwig
2015-11-13 13:46 ` [PATCH 6/9] srp: " Christoph Hellwig
2015-11-17 19:56   ` Bart Van Assche
2015-11-18 14:03     ` Christoph Hellwig
2015-11-13 13:46 ` [PATCH 7/9] IB/iser: Use a dedicated descriptor for login Christoph Hellwig
2015-11-15  9:14   ` Or Gerlitz
2015-11-13 13:46 ` [PATCH 8/9] IB/iser: Use helper for container_of Christoph Hellwig
2015-11-13 13:46 ` [PATCH 9/9] IB/iser: Convert to CQ abstraction Christoph Hellwig
2015-11-15  9:21   ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447422410-20891-4-git-send-email-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@fb.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sagig@dev.mellanox.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®