From: Nizam Haider <nizamhaider786@gmail.com>
To: lidza.louina@gmail.com
Cc: markh@compro.net, gregkh@linuxfoundation.org,
sudipm.mukherjee@gmail.com,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Nizam Haider <nizamhaider786@gmail.com>,
Nizam Haider <nijamh@cdac.in>
Subject: [PATCH v2 4/5] Staging: dgnc: dgnc_neo.c Braces {} should be used on all arms of this statement
Date: Fri, 13 Nov 2015 21:03:56 +0530 [thread overview]
Message-ID: <1447428837-24098-4-git-send-email-nizamhaider786@gmail.com> (raw)
In-Reply-To: <1447428837-24098-1-git-send-email-nizamhaider786@gmail.com>
Fix Checlpatch warning
HECK: braces {} should be used on all arms of this statement
Signed-off-by: Nizam Haider <nijamh@cdac.in>
---
drivers/staging/dgnc/dgnc_neo.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index e980150..99b230f 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
+++ b/drivers/staging/dgnc/dgnc_neo.c
@@ -1108,9 +1108,10 @@ static void neo_copy_data_from_uart_to_queue(struct channel_t *ch)
* On the other hand, if the UART IS in FIFO mode, then ask
* the UART to give us an approximation of data it has RX'ed.
*/
- if (!(ch->ch_flags & CH_FIFO_ENABLED))
+ if (!(ch->ch_flags & CH_FIFO_ENABLED)) {
total = 0;
- else {
+ }
+ else {
total = readb(&ch->ch_neo_uart->rfifo);
/*
--
1.8.1.4
next prev parent reply other threads:[~2015-11-13 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 15:33 [PATCH v2 1/5] Staging: dgnc: dgnc_neo.c: usleep_range is preferred over udelay Nizam Haider
2015-11-13 15:33 ` [PATCH v2 2/5] Staging: dgnc: dgnc_neo.c: Logical continuations should be on the previous line Nizam Haider
2015-11-13 15:33 ` [PATCH v2 3/5] Staging: dgnc: dgnc_neo.c: Spaces preferred around operators Nizam Haider
2015-11-13 15:33 ` Nizam Haider [this message]
2015-11-14 6:43 ` [PATCH v2 4/5] Staging: dgnc: dgnc_neo.c Braces {} should be used on all arms of this statement Sudip Mukherjee
2015-11-13 15:33 ` [PATCH v2 5/5] Staging: dgnc: dgnc_tty: Typo error dgnc_wmove comment Nizam Haider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447428837-24098-4-git-send-email-nizamhaider786@gmail.com \
--to=nizamhaider786@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
--cc=nijamh@cdac.in \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®