From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbbKPQ4B (ORCPT ); Mon, 16 Nov 2015 11:56:01 -0500 Received: from mga02.intel.com ([134.134.136.20]:34073 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751397AbbKPQz7 (ORCPT ); Mon, 16 Nov 2015 11:55:59 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,303,1444719600"; d="scan'208";a="601197841" Message-ID: <1447692962.31665.145.camel@linux.intel.com> Subject: Re: [PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL From: Andy Shevchenko To: Arnd Bergmann , Greg Kroah-Hartman Cc: linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Heikki Krogerus Date: Mon, 16 Nov 2015 18:56:02 +0200 In-Reply-To: <1447688894-2936779-4-git-send-email-arnd@arndb.de> References: <1447688894-2936779-1-git-send-email-arnd@arndb.de> <1447688894-2936779-4-git-send-email-arnd@arndb.de> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-11-16 at 16:48 +0100, Arnd Bergmann wrote: > The Intel MID support got split out from the PCI 8250 driver, > and that now causes a build error when no other driver selects > CONFIG_RATIONAL: Already published. https://lkml.org/lkml/2015/11/12/272 It's not first time you send patches that already have been published. I think you use some testing automation which doesn't take into consideration what is sent in mailing lists. > > drivers/built-in.o: In function `mid8250_set_termios': > (.text+0x77418): undefined reference to `rational_best_approximation' > > This adds an explicit 'select' like the combined driver had before. > > Signed-off-by: Arnd Bergmann > Fixes: d9eda9bab237 ("serial: 8250_pci: Intel MID UART support to its > own driver") > Cc: Heikki Krogerus > Cc: Andy Shevchenko > --- >  drivers/tty/serial/8250/Kconfig | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/8250/Kconfig > b/drivers/tty/serial/8250/Kconfig > index e6f5e12a2d83..6412f1455beb 100644 > --- a/drivers/tty/serial/8250/Kconfig > +++ b/drivers/tty/serial/8250/Kconfig > @@ -373,6 +373,7 @@ config SERIAL_8250_MID >   depends on SERIAL_8250 && PCI >   select HSU_DMA if SERIAL_8250_DMA >   select HSU_DMA_PCI if X86_INTEL_MID > + select RATIONAL >   help >     Selecting this option will enable handling of the extra > features >     present on the UART found on Intel Medfield SOC and > various other -- Andy Shevchenko Intel Finland Oy