From: Marc Zyngier <marc.zyngier@arm.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Russell King <linux@arm.linux.org.uk>
Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/4] irqchip/gic: Deal with the active state across kexec and suspend/resume
Date: Mon, 16 Nov 2015 19:13:24 +0000 [thread overview]
Message-ID: <1447701208-18150-1-git-send-email-marc.zyngier@arm.com> (raw)
Now that the kernel uses EOImode==1 for the GIC, this uncovers a
number of cases where the active state is not correctly handled:
- When doing kexec, we directly call the irq_eoi() method, which may
violate ordering constraints, or leave interrupts active.
- When booting, we don't reset the active state, trusting whatever was
there before.
- When doing suspend/resume, we're not saving/restoring the active
state, which could result in lost interrupts if VMs were running at
this precise moment.
This has also uncovered a small bug in the way we restore enabled
interrupts (which could result in a fix to stable).
These patches are on top of v4.4-rc1.
Marc Zyngier (4):
arm: kexec: Deactivate in-flight interrupts
irqchip/gic: Make sure all interrupts are deactivated at boot
irqchip/gic: Clear enable bits before restoring them
irqchip/gic: Add save/restore of the active state
arch/arm/kernel/machine_kexec.c | 11 ++++++++++-
drivers/irqchip/irq-gic-common.c | 13 +++++++++----
drivers/irqchip/irq-gic.c | 38 ++++++++++++++++++++++++++++++++++++--
3 files changed, 55 insertions(+), 7 deletions(-)
--
2.1.4
next reply other threads:[~2015-11-16 19:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 19:13 Marc Zyngier [this message]
2015-11-16 19:13 ` [PATCH 1/4] arm: kexec: Deactivate in-flight interrupts Marc Zyngier
2015-11-16 19:13 ` [PATCH 2/4] irqchip/gic: Make sure all interrupts are deactivated at boot Marc Zyngier
2015-11-17 13:30 ` [tip:irq/urgent] " tip-bot for Marc Zyngier
2015-11-16 19:13 ` [PATCH 3/4] irqchip/gic: Clear enable bits before restoring them Marc Zyngier
2015-11-17 13:30 ` [tip:irq/urgent] " tip-bot for Marc Zyngier
2015-11-16 19:13 ` [PATCH 4/4] irqchip/gic: Add save/restore of the active state Marc Zyngier
2015-11-17 13:31 ` [tip:irq/urgent] irqchip/gic: Add save/ restore " tip-bot for Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447701208-18150-1-git-send-email-marc.zyngier@arm.com \
--to=marc.zyngier@arm.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®