From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751807AbbKQCfF (ORCPT ); Mon, 16 Nov 2015 21:35:05 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:60403 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751421AbbKQCfD (ORCPT ); Mon, 16 Nov 2015 21:35:03 -0500 X-Listener-Flag: 11101 From: Hongzhou Yang To: Linus Walleij , Matthias Brugger CC: Hongzhou Yang , Yingjoe Chen , Axel Lin , Maoguang Meng , Colin Ian King , , , , , , Sascha Hauer , Subject: [PATCH] pinctrl: mediatek: fix a memleak when do dt maps. Date: Mon, 16 Nov 2015 18:34:50 -0800 Message-ID: <1447727690-15251-1-git-send-email-hongzhou.yang@mediatek.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org configs will kmemdup to dup_configs in pictrl util function. So configs need to be freed. Signed-off-by: Hongzhou Yang --- Fix a memleak issue. drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index bbf0230..0000b5a 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -568,9 +568,10 @@ static int mtk_pctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, } } - return 0; + err = 0; fail: + kfree(configs); return err; } -- 1.7.9.5