mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <byungchul.park@lge.com>
To: <mingo@kernel.org>, <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, efault@gmx.de, tglx@linutronix.de,
	yuyang.du@intel.com, pjt@google.com,
	Byungchul Park <byungchul.park@lge.com>
Subject: [PATCH] sched: modify the comment about lock assumption in migrate_task_rq_fair()
Date: Wed, 18 Nov 2015 09:34:59 +0900	[thread overview]
Message-ID: <1447806899-20303-1-git-send-email-byungchul.park@lge.com> (raw)

From: Byungchul Park <byungchul.park@lge.com>

The comment describing migrate_task_rq_fair() says that the caller
should hold p->pi_lock. But in some other case, the caller can hold
task_rq(p)->lock instead of p->pi_lock. So the comment is broken and
this patch fixs it.

Signed-off-by: Byungchul Park <byungchul.park@lge.com>
---
 kernel/sched/fair.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 077076f..6f43dfd 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5006,8 +5006,7 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int sd_flag, int wake_f
 /*
  * Called immediately before a task is migrated to a new cpu; task_cpu(p) and
  * cfs_rq_of(p) references at time of call are still valid and identify the
- * previous cpu.  However, the caller only guarantees p->pi_lock is held; no
- * other assumptions, including the state of rq->lock, should be made.
+ * previous cpu. The caller guarantees p->pi_lock or task_rq(p)->lock is held.
  */
 static void migrate_task_rq_fair(struct task_struct *p, int next_cpu)
 {
-- 
1.7.9.5


             reply	other threads:[~2015-11-18  0:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18  0:34 byungchul.park [this message]
2015-11-23 16:24 ` [tip:sched/core] sched/fair: Modify the comment about lock assumptions " tip-bot for Byungchul Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447806899-20303-1-git-send-email-byungchul.park@lge.com \
    --to=byungchul.park@lge.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=tglx@linutronix.de \
    --cc=yuyang.du@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®