From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756497AbbKRR15 (ORCPT ); Wed, 18 Nov 2015 12:27:57 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:34637 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbbKRR14 (ORCPT ); Wed, 18 Nov 2015 12:27:56 -0500 Message-ID: <1447867675.23650.0.camel@pengutronix.de> Subject: Re: [PATCH V6 RESEND 2/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC From: Philipp Zabel To: Chen Feng Cc: linux-kernel@vger.kernel.org, puck.chen@aliyun.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org Date: Wed, 18 Nov 2015 18:27:55 +0100 In-Reply-To: <1446175164-116524-2-git-send-email-puck.chen@hisilicon.com> References: <1446175164-116524-1-git-send-email-puck.chen@hisilicon.com> <1446175164-116524-2-git-send-email-puck.chen@hisilicon.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, den 30.10.2015, 11:19 +0800 schrieb Chen Feng: > Add reset driver for hi6220-hikey board,this driver supply deassert > of IP on hi6220 SoC. > > Signed-off-by: Chen Feng [...] > diff --git a/drivers/reset/hisilicon/Kconfig b/drivers/reset/hisilicon/Kconfig > new file mode 100644 > index 0000000..26bf95a > --- /dev/null > +++ b/drivers/reset/hisilicon/Kconfig > @@ -0,0 +1,5 @@ > +config COMMON_RESET_HI6220 > + tristate "Hi6220 Reset Driver" > + depends on (ARCH_HISI && RESET_CONTROLLER) > + help > + Build the Hisilicon Hi6220 reset driver. Why is this configurable? Can't you just drop the Kconfig and use ... > diff --git a/drivers/reset/hisilicon/Makefile b/drivers/reset/hisilicon/Makefile > new file mode 100644 > index 0000000..c932f86 > --- /dev/null > +++ b/drivers/reset/hisilicon/Makefile > @@ -0,0 +1 @@ > +obj-$(CONFIG_COMMON_RESET_HI6220) += hi6220_reset.o ... obj-$(CONFIG_ARCH_HISI) += hi6220_reset.o here? regards Philipp