mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jia He <hejianet@gmail.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	Yury Norov <yury.norov@gmail.com>, Tejun Heo <tj@kernel.org>,
	Martin Kepplinger <martink@posteo.de>,
	George Spelvin <linux@horizon.com>,
	Ingo Molnar <mingo@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Jia He <hejianet@gmail.com>
Subject: [PATCH 3/3] linux/bitmap: Replace find_fisrt_{zero_}bit with the new lightweight api
Date: Thu, 19 Nov 2015 10:31:54 +0800	[thread overview]
Message-ID: <1447900314-5727-4-git-send-email-hejianet@gmail.com> (raw)
In-Reply-To: <1447900314-5727-1-git-send-email-hejianet@gmail.com>

This is to replace find_fisrt_{zero_}bit with the new lightweight api 
all_bit_is_{one,zero} in bitmap_{full,empty}

Signed-off-by: Jia He <hejianet@gmail.com>
---
 include/asm-generic/bitops/find.h | 3 +++
 include/linux/bitmap.h            | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/include/asm-generic/bitops/find.h b/include/asm-generic/bitops/find.h
index 998d4d5..1ec1d45 100644
--- a/include/asm-generic/bitops/find.h
+++ b/include/asm-generic/bitops/find.h
@@ -59,4 +59,7 @@ extern unsigned long find_first_zero_bit(const unsigned long *addr,
 
 #endif /* CONFIG_GENERIC_FIND_FIRST_BIT */
 
+extern unsigned int all_bit_is_one(const unsigned long *addr, unsigned size);
+extern unsigned int all_bit_is_zero(const unsigned long *addr, unsigned size);
+
 #endif /*_ASM_GENERIC_BITOPS_FIND_H_ */
diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
index 15524f6..8877a68 100644
--- a/include/linux/bitmap.h
+++ b/include/linux/bitmap.h
@@ -281,7 +281,7 @@ static inline int bitmap_empty(const unsigned long *src, unsigned nbits)
 	if (small_const_nbits(nbits))
 		return ! (*src & BITMAP_LAST_WORD_MASK(nbits));
 
-	return find_first_bit(src, nbits) == nbits;
+	return all_bit_is_zero(src, nbits);
 }
 
 static inline int bitmap_full(const unsigned long *src, unsigned int nbits)
@@ -289,7 +289,7 @@ static inline int bitmap_full(const unsigned long *src, unsigned int nbits)
 	if (small_const_nbits(nbits))
 		return ! (~(*src) & BITMAP_LAST_WORD_MASK(nbits));
 
-	return find_first_zero_bit(src, nbits) == nbits;
+	return all_bit_is_one(src, nbits);
 }
 
 static __always_inline int bitmap_weight(const unsigned long *src, unsigned int nbits)
-- 
2.5.0


  parent reply	other threads:[~2015-11-19  2:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19  2:31 [PATCH 0/3] Improve bitmap_empty and bitmap_full Jia He
2015-11-19  2:31 ` [PATCH 1/3] linux/bitmap: Move 2 mask macro to bitops.h Jia He
2015-11-22 19:17   ` Andy Shevchenko
2015-11-19  2:31 ` [PATCH 2/3] lib: Introduce 2 find bit api: all_is_bit_{one,zero} Jia He
2015-11-20  8:52   ` Geert Uytterhoeven
2015-11-20 13:57   ` Michal Nazarewicz
2015-11-19  2:31 ` Jia He [this message]
2015-11-19  2:53   ` [PATCH 3/3] linux/bitmap: Replace find_fisrt_{zero_}bit with the new lightweight api kbuild test robot
2015-11-19  3:24     ` hejianet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447900314-5727-4-git-send-email-hejianet@gmail.com \
    --to=hejianet@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=dvlasenk@redhat.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    --cc=linux@rasmusvillemoes.dk \
    --cc=martink@posteo.de \
    --cc=mina86@mina86.com \
    --cc=mingo@kernel.org \
    --cc=tj@kernel.org \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®