From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758037AbbKSITg (ORCPT ); Thu, 19 Nov 2015 03:19:36 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:39728 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756094AbbKSIR7 (ORCPT ); Thu, 19 Nov 2015 03:17:59 -0500 X-AuditID: cbfee68d-f79286d000007523-64-564d85b32da8 From: Chanwoo Choi To: myungjoo.ham@samsung.com, kyungmin.park@samsung.com Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Chanwoo Choi Subject: [PATCH 3/6] PM / devfreq: Add show_one macro to delete the duplicate code Date: Thu, 19 Nov 2015 17:17:47 +0900 Message-id: <1447921070-6045-4-git-send-email-cw00.choi@samsung.com> X-Mailer: git-send-email 1.8.0 In-reply-to: <1447921070-6045-1-git-send-email-cw00.choi@samsung.com> References: <1447921070-6045-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrILMWRmVeSWpSXmKPExsWyRsSkRHdzq2+YQdNmXYvrX56zWpxtesNu cXnXHDaLz71HGC1uN65gc2D16NuyitHj8ya5AKYoLpuU1JzMstQifbsEroylq9ezF9zhrrh+ eAtjA+NFzi5GTg4JAROJj98fMELYYhIX7q1nA7GFBFYwStydkwpT86R9C1ANF1B8KaPE4l1r 2SGcL4wSh09dYwWpYhPQktj/4gZYt4iAucSupT/BbGaBJInza5vAaoQFQiR+L5gGFOfgYBFQ lbhzMBQkzCvgIjHz825miGVyEh/2PGIHsTkFXCWOrz/FCHGQi8St7idgeyUEfrNJXD31HqyI RUBA4tvkQywgMyUEZCU2HYCaIylxcMUNlgmMwgsYGVYxiqYWJBcUJ6UXGeoVJ+YWl+al6yXn 525iBIbs6X/Pencw3j5gfYhRgINRiYd3wymfMCHWxLLiytxDjKZAGyYyS4km5wMjI68k3tDY zMjC1MTU2Mjc0kxJnFdR6mewkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6pBsYaw8U7X8n90Cg8 2Mwwa8nc9Rd/dH6/kfSpPyDBd859lpneK96U/096Wnu+xXf/rzNqie4aEhzV8/okKtRPWByd srDsllHPj1XPpVozNr53lZJg8Ii90pL4UunXGy0OS8Ekj5LZRUbfHBjMP7O1L93Odnzfv9h5 eb/u/+wqTd/9c0aUotc0JnklluKMREMt5qLiRAD5C4hiVAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeLIzCtJLcpLzFFi42I5/e+xgO7mVt8wgzOt6hbXvzxntTjb9Ibd 4vKuOWwWn3uPMFrcblzB5sDq0bdlFaPH501yAUxRDYw2GamJKalFCql5yfkpmXnptkrewfHO 8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUDrlBTKEnNKgUIBicXFSvp2mCaEhrjpWsA0Ruj6 hgTB9RgZoIGENYwZS1evZy+4w11x/fAWxgbGi5xdjJwcEgImEk/atzBC2GISF+6tZ+ti5OIQ EljKKLF411p2COcLo8ThU9dYQarYBLQk9r+4wQZiiwiYS+xa+hPMZhZIkji/tgmsRlggROL3 gmlAcQ4OFgFViTsHQ0HCvAIuEjM/72aGWCYn8WHPI3YQm1PAVeL4+lNgRwgB1dzqfsI+gZF3 ASPDKkaJ1ILkguKk9FzDvNRyveLE3OLSvHS95PzcTYzgyHgmtYPx4C73Q4wCHIxKPLwbTvmE CbEmlhVX5h5ilOBgVhLhfVDmGybEm5JYWZValB9fVJqTWnyI0RToronMUqLJ+cCozSuJNzQ2 MTOyNDI3tDAyNlcS59X3NAoTEkhPLEnNTk0tSC2C6WPi4JRqYJS8JZjdddzj8/78nZLLDp36 t9jyaMMiuc9M4Td2RYp1B63J8HvmuWrnxKKnc3R7zluJv78lqmGsGKJcVfY9UfS+WVP3xLmX p+/S5D0qFLXmfcIP32/LxBYWbP/f+L7yTbVd7u2L3HvKf57c2cAkdvCNnVHS0lUesYyckyc7 /QxWenH0p8lGL3ElluKMREMt5qLiRAA/7ABFogIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds the 'show_one' macro to simplify the duplicate code of both max_freq_show() and min_freq_show(). Signed-off-by: Chanwoo Choi --- drivers/devfreq/devfreq.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index ca848cc6a8fd..49fc7dcf664c 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -921,12 +921,6 @@ unlock: return ret; } -static ssize_t min_freq_show(struct device *dev, struct device_attribute *attr, - char *buf) -{ - return sprintf(buf, "%lu\n", to_devfreq(dev)->min_freq); -} - static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { @@ -953,13 +947,17 @@ unlock: mutex_unlock(&df->lock); return ret; } -static DEVICE_ATTR_RW(min_freq); -static ssize_t max_freq_show(struct device *dev, struct device_attribute *attr, - char *buf) -{ - return sprintf(buf, "%lu\n", to_devfreq(dev)->max_freq); +#define show_one(name) \ +static ssize_t name##_show \ +(struct device *dev, struct device_attribute *attr, char *buf) \ +{ \ + return sprintf(buf, "%lu\n", to_devfreq(dev)->name); \ } +show_one(min_freq); +show_one(max_freq); + +static DEVICE_ATTR_RW(min_freq); static DEVICE_ATTR_RW(max_freq); static ssize_t available_frequencies_show(struct device *d, -- 1.9.1