From: LABBE Corentin <clabbe.montjoie@gmail.com>
To: alexandre.belloni@free-electrons.com, a.zummo@towertech.it,
linux-arm-kernel@lists.infradead.org,
maxime.ripard@free-electrons.com, wens@csie.org
Cc: LABBE Corentin <clabbe.montjoie@gmail.com>,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com
Subject: [PATCH 2/3] rtc: sunxi: constify the data_year_param structure
Date: Thu, 19 Nov 2015 11:50:09 +0100 [thread overview]
Message-ID: <1447930210-27008-2-git-send-email-clabbe.montjoie@gmail.com> (raw)
In-Reply-To: <1447930210-27008-1-git-send-email-clabbe.montjoie@gmail.com>
The data_year_param struct is never modified, so lets constify it.
This permit to remove cast since of_device_id is const also.
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/rtc/rtc-sunxi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-sunxi.c b/drivers/rtc/rtc-sunxi.c
index b4f35ac..0c08a5b 100644
--- a/drivers/rtc/rtc-sunxi.c
+++ b/drivers/rtc/rtc-sunxi.c
@@ -133,7 +133,7 @@ struct sunxi_rtc_data_year {
unsigned char leap_shift; /* bit shift to get the leap year */
};
-static struct sunxi_rtc_data_year data_year_param[] = {
+static const struct sunxi_rtc_data_year data_year_param[] = {
[0] = {
.min = 2010,
.max = 2073,
@@ -151,7 +151,7 @@ static struct sunxi_rtc_data_year data_year_param[] = {
struct sunxi_rtc_dev {
struct rtc_device *rtc;
struct device *dev;
- struct sunxi_rtc_data_year *data_year;
+ const struct sunxi_rtc_data_year *data_year;
void __iomem *base;
int irq;
};
@@ -468,7 +468,7 @@ static int sunxi_rtc_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "Unable to setup RTC data\n");
return -ENODEV;
}
- chip->data_year = (struct sunxi_rtc_data_year *) of_id->data;
+ chip->data_year = of_id->data;
/* clear the alarm count value */
writel(0, chip->base + SUNXI_ALRM_DHMS);
--
2.4.10
next prev parent reply other threads:[~2015-11-19 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 10:50 [PATCH 1/3] rtc: sunxi: fix signedness issues LABBE Corentin
2015-11-19 10:50 ` LABBE Corentin [this message]
2015-11-23 7:18 ` [PATCH 2/3] rtc: sunxi: constify the data_year_param structure Chen-Yu Tsai
2015-11-30 19:04 ` Alexandre Belloni
2015-11-19 10:50 ` [PATCH 3/3] rtc: sunxi: use of_device_get_match_data LABBE Corentin
2015-11-23 7:18 ` Chen-Yu Tsai
2015-11-30 19:05 ` Alexandre Belloni
2015-11-23 7:18 ` [PATCH 1/3] rtc: sunxi: fix signedness issues Chen-Yu Tsai
2015-11-30 19:04 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447930210-27008-2-git-send-email-clabbe.montjoie@gmail.com \
--to=clabbe.montjoie@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=rtc-linux@googlegroups.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®