From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ECC1471D10; Fri, 4 Sep 2026 15:08:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.18 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788534498; cv=fail; b=uHb2iX13DIN0GwT5RvcW/u7VQT5LhqUposBVwftRDTLg10VxI68EytYpLNdWLC5PdKkqKA/dJ0OxUBb1Iai4voJO5d42Lyp5Q2TbzZRZtdnmCIoHqQy/rg4fiMpAywXw8yTun1o6zzjyJ9WCoukXSThfnSpIfzdWoTYvkq2QBB8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788534498; c=relaxed/simple; bh=JHFJRZC7aT2Iatz/Jjg5ekeq+MPKRo3y81VuaekqnI4=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=usWCXerp8tIj67BhymHZiUfas9C7Og0b1xuKwKy0LNewlb1ZBiWpw1oxm0BXVFhp4A9Rla0Mri4iftanVaV9KF6KetF6FX7e4VD5MdmsOxdch0wvTefAAAMo4AGA4Xln1V/GlGyjjz4/V+FQo3KI9cTwIo+65EvsVIY8+AE9UCQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VxLiKnX6; arc=fail smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VxLiKnX6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788534496; x=1820070496; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=JHFJRZC7aT2Iatz/Jjg5ekeq+MPKRo3y81VuaekqnI4=; b=VxLiKnX6pPXZa1PqgwXRyC2JyEBf1AVbmfh6qe3/cWUSfPBOnI+y+Adc ApRnB78bKkyyowFjfXvoCL+HIZzmFLZi98yQiy3ZJQGLkx1mwee5l/37z qoeR8JhVo27Y6kUASCxVPDOhnJ1nCejy91r6LJgDAfvO/q0WWQ67+1yuZ CjXKg5ZRCngg7fFEcPPhVbXY+WgutFJp6HwIqyQWAX/6TdHjwTqq1FXvj 8ZW7nQqRUMEpYNTygw64w9NwiaBVtTsu6cYq8xNME3+pAHtRQT4xEYm6i ithRhPDrl0joHTfd6IwEFNXMvb0lx8MSoDDRIp2IrrBrDfDwpIwlU71yw g==; X-CSE-ConnectionGUID: gKno5hTaSdyRWjQBQd2ZUg== X-CSE-MsgGUID: qzuS6wX6SPexSSf82w+Ncg== X-IronPort-AV: E=McAfee;i="6800,10657,11895"; a="88180983" X-IronPort-AV: E=Sophos;i="6.25,262,1779174000"; d="scan'208";a="88180983" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2026 08:08:15 -0700 X-CSE-ConnectionGUID: QGGa6mSrSK2BTuTP9KJOlw== X-CSE-MsgGUID: E0MvG8uPRlSuWIXXwURqvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,262,1779174000"; d="scan'208";a="272003215" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by fmviesa004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2026 08:08:15 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Fri, 4 Sep 2026 08:08:15 -0700 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46 via Frontend Transport; Fri, 4 Sep 2026 08:08:15 -0700 Received: from CH5PR02CU005.outbound.protection.outlook.com (40.107.200.41) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Fri, 4 Sep 2026 08:08:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BWDn2o/1OuHrk96QQ6bqbSKQ8oyHJ6vw1gsv+z0hrxcxJtFV/RffXotfkzNJlt/xEgWQmDIhy7vPsbIeAEaLkicQ5DI4t0HtQlb+yPJ7eYuAMgb2QYL56t6Bk2ulJsMeenngLlsDV61KxqMH9EoSCnwTIrC9SkRvl+ARTXujYCCDWbuhzoBHdERw/kB4xyYsPJYlZupFdAVidTs6JqI1BVvYj4u+ZkGgU+eR0165SCeyX7jlCKr/080bpD38eg32X2+fNcGUKb+sGiCuYd8c2KB+c48ay2AFq3Ow82KQ+7kMRhvg9e/XKJ6KyjaQhoi4LpM7pmNJqo2jGjR//IIzbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UDkaguzm6fv0k9j/jCSwxhnul/hppa7Y3WFU3a3ZuOA=; b=ugd91YZhKRzenKtyy2RBPz4KXypM7uu91d0WoVsYXDXZRMnRVLhdJATfGOb3BO8U7EsHHjr/qp0oj3716MvHRSQ8+Qyynx70PXZ9E79cXllbyj9K0yqUkcBItwPQRb+aF17IRJXP+sk6OxA18s0d26YVoQ0kETop9kQztaxHgqkbPkrOK3n42qKYSBli6wZ5+2d4XqJRY9pN6EOn00cYqeuPQSnUioDSiFis705CuLp7XteBNqjXjbIYAnAf3Lt5iOmer5v4Y2lk4GwPiy8F9IulM9RcXIUps7GMyY9VS12BcorLzV1PmgWpNpucurt/4En1jEeQKDVqJgeu4yM7bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from LV3PR11MB8508.namprd11.prod.outlook.com (2603:10b6:408:1b4::8) by SA1PR11MB8573.namprd11.prod.outlook.com (2603:10b6:806:3ab::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.13; Fri, 4 Sep 2026 15:08:06 +0000 Received: from LV3PR11MB8508.namprd11.prod.outlook.com ([fe80::a1e8:1786:e5d1:8e51]) by LV3PR11MB8508.namprd11.prod.outlook.com ([fe80::a1e8:1786:e5d1:8e51%5]) with mapi id 15.21.0360.008; Fri, 4 Sep 2026 15:08:06 +0000 Message-ID: <1447effd-b291-4253-b63e-ec36828fc2af@intel.com> Date: Fri, 4 Sep 2026 17:08:01 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] ice: restore DDP state during PFR recovery To: Aaron Ma , Tony Nguyen , Andrew Lunn , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , , CC: "moderated list:INTEL ETHERNET DRIVERS" References: <20260903074706.602087-1-aaron.ma@canonical.com> From: Przemek Kitszel Content-Language: en-US In-Reply-To: <20260903074706.602087-1-aaron.ma@canonical.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0312.eurprd04.prod.outlook.com (2603:10a6:10:2b5::17) To LV3PR11MB8508.namprd11.prod.outlook.com (2603:10b6:408:1b4::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR11MB8508:EE_|SA1PR11MB8573:EE_ X-MS-Office365-Filtering-Correlation-Id: afdd5e16-6f7b-48ca-967f-08df0a9652f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|1800799024|376014|10067099003|22082099003|56012099006|11063799006|18002099003; X-Microsoft-Antispam-Message-Info: b4jH/Dmh4XlPvnNE/q8PPe6/KkfhozBma4WoKt80RpRB/eWvHbpRYqEFvB5l1WqnvDJk3G9FVRnWSn1fnNtQp8k0QoBOpJJSAxdl41ur83WV1Md5TSNNkuflPqX0+gW8psxdlqS8uIvoQLc1V+PZECz+NPHQI1GiEc6y+ovPnslGADrRnKStcBnG9gZu+Yas0Qs1HsxRkcgOu4mzc/wpB5qnMpguo/zDh3skctTBu7cH2RQCC1e17xVfcqHtSCK5xAIqcLXKNS69Oh1o6FA4MmOYBjvEvd2dnGJpGlpn8qHg4a/PkKutWY61HOjoRxEfJYXFuj5J/AWl0nMAWvRBzyZseDoZImMzE7L4SPzGdTssmE2Yg8IVewgpD98NAYuwdJWcIjZYF12KJQuIu+wZlrSBFGGBx04rXlQ32aW7/OnTuuZktsLW/8N7jTMYCUV6Qeqt+eGGSg1qOuSjg88hNg5HKral9W0jcGAX2O1/xHdKrQ+DCWpjDlov347wZ1CD+h40IHNRdvUYVgJtEcuLuzk2hXsDFBuBg606g/JNKLUKdBszmPn6qhZgf99aLGmekeo1LAtV0tYGxVS26Xx1UyYGFdaWfwNmbPou+Vy820as5WHxcvYr4TRKp4/+nxYfTNCOS8ykVxQlS4YdeVQoGSfQmJ2dfXmzjfiPNNtOxd0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV3PR11MB8508.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(1800799024)(376014)(10067099003)(22082099003)(56012099006)(11063799006)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YklkRUg3cXZIZUdXN2lJQ3NOUGlWaFRLVXNoRGd2YXBHRWl0RVdBSFFpZ25E?= =?utf-8?B?a013UUhaOThiWDEvODNiWmtyc01UVEdBaHlqaFliUnFYWHZQM2t4cDJ1TThU?= =?utf-8?B?dWJ2Q3o3NlJ0R25tQjJ2MkhlbTNWcmY1NnAyUnpHQUxLZjdZek8rZzlIengx?= =?utf-8?B?SGVuUStpRXNCNlkyWDJVYjRlcGFmVjZGb242cC9mSm54d1lPRUtOcjd4M1c1?= =?utf-8?B?ZDUwRlZVaFlDLzdCS01VNFJzMWZmRkxJVGhmMkUrcXBCOTVKaXk5cm1EWmYx?= =?utf-8?B?OFVJdGFJTllGMTFOcW5iR0xVNjd6THJHZ3JsaEZqUFE1U2NIczRNVkxpSVUr?= =?utf-8?B?V0RWRnFzRlBoMkhzYllxTmFiTEIxeUNjdUtJR0JGclNhNDRCdGtUSjIxY0xH?= =?utf-8?B?N1YxclVMRWhmaHMvSVBxWDZ3dFJ0NUdXYmJWTDkrK3lWWGJTeFdPN200em9L?= =?utf-8?B?VHp1cHpqV2JsWVN2QTBOK2NEQkJ5TTM2OHlNNVRNWXhjcDdkZnpXS3FnWEZy?= =?utf-8?B?NXFqZktVWXJTUXFSYk5MaFRraUVTNGsvT1g5YzlzcG8yRWZCa3ZXdmVnL0Uw?= =?utf-8?B?OFlWMjNYMTFxSDhMYmFEN2o3N1gxYUZPeUhMRE5MbHhrVDBKZ2hjclNJUHcv?= =?utf-8?B?a1VXZWFVWHN1dFZEbU5ydGx6TUlXSWxlenkzZzVHS1hqQVlBTzl3RmJKL2R1?= =?utf-8?B?QncrR1AwSUZ0U2RJRE13dnFCUTd4ck54c2tHQUV2MmZlVTlkaVBXY1ZLU0Zp?= =?utf-8?B?R1o5R3FVNUNwZEtoWVVOdmpaT2hoRWV6YXE0dVgrOVJmSmw2MUNGcXBHNGRj?= =?utf-8?B?QlVYUFppZXk4YVVlelp0K3Jhdmc1VmJhaTVta3pLUEorZzh4TndoS29xamVL?= =?utf-8?B?bVJxUUhkUW40ejZkVFlvVElpeE5NUmw0cENGSW9JS0ZZOGUzU0V6V2p4ckxt?= =?utf-8?B?ZFBLQVZtaEh6R0JKbEwrdWQrbzNsWU5IamQ2a0NtYnhvdm9iZVQvVTlHcEZ5?= =?utf-8?B?VU1mQlZNUlhaeVNEaFZ2Uk05T1NZTHJJRTV1a3BWMVo4NVlxOWQyKzIrNDQ5?= =?utf-8?B?dmlDbEJtZ3VRSnhpRVd4QXp1YzZjeXo1Z1dxYm5Ba2tqUFRqeUtXWmR3YmV0?= =?utf-8?B?M0xTYnorVVhpYm5BVmhXTTNFRWNFL3hUWGlkOVEvSWJFNHBlQ3VnNnFxd0lj?= =?utf-8?B?L1pKSDFST0lZWUZBMnF6UWFEKzRQd2VjTFpxSXJKeXFFd3ZPOWhObElSNHhp?= =?utf-8?B?NVBWRGVKOU1rNUVaM0s2dVFUcFJiSndyekIrU1hZbWFjbzNFUlNmdk9LV09F?= =?utf-8?B?bUU5dlJZWVlCV0l2WG16d3NWR2dna0tDbWIrMmozZEhyZ2FQS3crbk5QMXdQ?= =?utf-8?B?TkhGZHgrK2FyeGx2NFRQeTF1cFBTNlRRWGxOYTcrZ0ROUkt2blEzMU41UHNp?= =?utf-8?B?WWlERDVjeUlteHhmTk1WK04xTWYvU055REppUzdiVnRmRWxjcXUyakprU3h5?= =?utf-8?B?clE1MWNVSlh0WnJRZGNRS2FsQzZzZElDbzExWHdXU2dNZEE5bzN6VTN5T0FS?= =?utf-8?B?dXI3L0tCM1pSNXg2WnNZanoyUExwTk5FTWRaa3BlY2lqQU9YUXJZVW5hbE1j?= =?utf-8?B?cThtNm50bk83d0JUWUViMjZwSTB4b09GSG1lT1V1NGJDb0dncmxZQTBCNDZl?= =?utf-8?B?UU8vdU03RG1pT2tYMWpPSWhEdmxyMWgzRmFrOUhXbExCTzVnZ2hyZ1liM2tr?= =?utf-8?B?RnBTZjhYZjBRTDBvdzNPaXpmZHZkWDQwOE5iMVVlMi9wRVI3NzlRR2t5RFhy?= =?utf-8?B?UTFlb1h2dVV1QzRTSnF1WGxySEI3VWVIZ05ZVElwWkJ3eEN5RVNMQ2N4Q2pk?= =?utf-8?B?c0lUNXdtd1NGTnhVMVBHeVVCdldkamlhZ1JDa1JMZWxPZUJiaWs5N2FPVi9z?= =?utf-8?B?VzZQVGI0SmZ3TUh2N0JhcHV0UFptNnN1V0JHMjN1UHk5Z3NyOUd2bzk4Q0FB?= =?utf-8?B?bmRmZkVtd1RZU1JQbmgxL1p5emlhanVIWmltUTVmVkVoeVREZTIzVmFZSFRN?= =?utf-8?B?a0NuQm04Q3A5a1pQYWcyL0lGZWdjRlJxNXRJSlEvTXBpM085MXVMc3BwcG4y?= =?utf-8?B?TWRkM1pleTl6Y0JXdHZDOUg2REF5ejJxN3I2WUVkcEo5NDF6U1BNWkxscnRG?= =?utf-8?B?QWtwZnhjenRBV21ZN1MyZlVVQ2Yrdk00ZzVjemRjU1p5K3JlWFR6OFd0YkVQ?= =?utf-8?B?Y3k3SHkzbXRMWjF6WExGa25NSi9xLzljaEpNQ1JHc2FENTRDdnhFYWhhWm9F?= =?utf-8?B?K21EQkJKeVVnN1duWCt4WmhXZlVFZ1pYY280dzdXQmxVdExJNm1CUGJmOXBx?= =?utf-8?Q?5fqUHSe00nI2qtCU=3D?= X-Exchange-RoutingPolicyChecked: JVVXjOa0qH4wIQgSFrMI+qtJUMsKdUId9m8vVUJk1CzbLmKMk2+cm6/0IMnTHchVK6K7eGxZHCgzZgVnvyypKCEsb1ri/pSxXJTRBTqT2p9/9yWQkd3TGpi2Siw+cIlhgNTYYVbW1SpgrlnCV8oVqFzy4+PlOf8qEGIya0i7uTzqrl+uMSWpF/+0v8kk7ajxexfPMa+XTQ7+L1cbdw/WegigD3HSvL+4+sMznm2cbTkjj17XSHBFu/uneft03a1VaSkXLLOn6CEkQ5MTrehklq7AOQ6tz26mZXA9WETCILT41YWgB8DekIj5CEzMRs5OZbA8YkPrn+LXBkFwAoc+pg== X-MS-Exchange-CrossTenant-Network-Message-Id: afdd5e16-6f7b-48ca-967f-08df0a9652f2 X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8508.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2026 15:08:06.5899 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JITIBx4wOJ1Gc96ZQlX8NoExDAy1d8w17CF4OabI+m47iwWyu2lyf1/tx5GdrqGFxfx+oj15lYZUZhV215xHprcH2hobHeoHKpcvN8u/Hwk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8573 X-OriginatorOrg: intel.com On 9/3/26 9:47 AM, Aaron Ma wrote: > The firmware package and switch recipes are shared by all PFs of an > adapter. However, each PF rebuilds independently after system resume. The > resulting package downloads and recipe updates can interleave, causing > firmware timeouts and leaving interfaces unusable. > > PFR also clears package-derived firmware state on affected devices. The > existing PFR path only rebuilds the driver's block tables, so VLAN recipe > programming can fail after the reset. > > The failure is reported as: > > ice 0000:04:00.0: Update pkg failed: err -5 > ice 0000:04:00.0: package load failed, -12 > ice 0000:04:00.0: Rebuild failed, unload and reload driver > > This was observed on an Intel E810-XXV-2 adapter (PCI ID 8086:159b, > revision 02) with NVM package 1.0.0.18 and ICE OS Default DDP package > 1.3.43.0. > > Serialize rebuilds across PFs of the same adapter, while allowing each PFR > to complete independently. Reload the DDP package from its cached copy and > restore the default DVM recipes before rebuilding the remaining PF state. > Abort recovery if either operation fails. > > Fixes: 462acf6aca85 ("ice: Enable DDP package download") > Signed-off-by: Aaron Ma we have FW-level lock for global (per-card) changes, we have also per-PF SW lock to protect global-update from given PF against unrelated AQ stuff You have added a protection for the case PF1 starts its SW preparation, then other PF starts the same and its first to grab the FW global lock, so PF1 could be confused. I fully support this approach, thank you! Reviewed-by: Przemek Kitszel