From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935048AbbKTIOt (ORCPT ); Fri, 20 Nov 2015 03:14:49 -0500 Received: from mail-lf0-f54.google.com ([209.85.215.54]:34575 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934361AbbKTIOo (ORCPT ); Fri, 20 Nov 2015 03:14:44 -0500 From: Rasmus Villemoes To: Sudeep Dutt , Greg Kroah-Hartman , Nikhil Rao , Ashutosh Dixit Cc: Rasmus Villemoes , linux-kernel@vger.kernel.org Subject: [PATCH] misc: mic: ERR_PTR expects -Exxx Date: Fri, 20 Nov 2015 09:14:23 +0100 Message-Id: <1448007266-8432-1-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.6.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These wouldn't be recognized by IS_ERR. There's no actual harm done, since the only caller ignores the return value. Signed-off-by: Rasmus Villemoes --- drivers/misc/mic/scif/scif_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mic/scif/scif_dma.c b/drivers/misc/mic/scif/scif_dma.c index 95a13c629a8e..f998daad1993 100644 --- a/drivers/misc/mic/scif/scif_dma.c +++ b/drivers/misc/mic/scif/scif_dma.c @@ -293,13 +293,13 @@ scif_add_mmu_notifier(struct mm_struct *mm, struct scif_endpt *ep) = kzalloc(sizeof(*mmn), GFP_KERNEL); if (!mmn) - return ERR_PTR(ENOMEM); + return ERR_PTR(-ENOMEM); scif_init_mmu_notifier(mmn, current->mm, ep); if (mmu_notifier_register(&mmn->ep_mmu_notifier, current->mm)) { kfree(mmn); - return ERR_PTR(EBUSY); + return ERR_PTR(-EBUSY); } list_add(&mmn->list, &ep->rma_info.mmn_list); return mmn; -- 2.6.1