From: David Woodhouse <dwmw2@infradead.org>
To: Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org
Cc: Joerg Roedel <jroedel@suse.de>,
linux-kernel@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 4/4] iommu/vt-d: Do access checks before calling handle_mm_fault()
Date: Fri, 20 Nov 2015 15:35:53 +0000 [thread overview]
Message-ID: <1448033753.89124.19.camel@infradead.org> (raw)
In-Reply-To: <1447773099-2444-5-git-send-email-joro@8bytes.org>
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
On Tue, 2015-11-17 at 16:11 +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> Not doing so is a bug and might trigger a BUG_ON in
> handle_mm_fault(). So add the proper permission checks
> before calling into mm code.
>
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
Acked-By: David Woodhouse <David.Woodhouse@intel.com>
As noted, I can't test it right now until I've replaced my test
hardware. Certainly looks better than the last version though :)
Thanks.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5691 bytes --]
next prev parent reply other threads:[~2015-11-20 15:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 15:11 [PATCH 0/4 v2] Implement access checks in iommu page fault paths Joerg Roedel
2015-11-17 15:11 ` [PATCH 1/4] iommu/amd: Do proper access checking before calling handle_mm_fault() Joerg Roedel
2015-11-17 15:11 ` [PATCH 2/4] iommu/amd: Correctly set flags for handle_mm_fault call Joerg Roedel
2015-11-17 15:11 ` [PATCH 3/4] iommu/amd: Cleanup error handling in do_fault() Joerg Roedel
2015-11-17 15:11 ` [PATCH 4/4] iommu/vt-d: Do access checks before calling handle_mm_fault() Joerg Roedel
2015-11-20 15:35 ` David Woodhouse [this message]
2015-12-14 14:41 ` Joerg Roedel
2015-11-18 14:07 ` [PATCH 0/4 v2] Implement access checks in iommu page fault paths Oded Gabbay
2015-11-18 16:13 ` Jesse Barnes
2015-11-27 12:07 ` Joerg Roedel
-- strict thread matches above, loose matches on Subject: below --
2015-11-10 13:26 [PATCH 0/4] " Joerg Roedel
2015-11-10 13:26 ` [PATCH 4/4] iommu/vt-d: Do access checks before calling handle_mm_fault() Joerg Roedel
2015-11-10 14:45 ` David Woodhouse
2015-11-10 14:52 ` Joerg Roedel
2015-11-10 17:43 ` Linus Torvalds
2015-11-10 17:57 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448033753.89124.19.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome