From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753170AbaAFLEN (ORCPT ); Mon, 6 Jan 2014 06:04:13 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:59095 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752672AbaAFLEL convert rfc822-to-8bit (ORCPT ); Mon, 6 Jan 2014 06:04:11 -0500 From: "Rafael J. Wysocki" To: Josh Triplett Cc: Rashika Kheria , linux-kernel@vger.kernel.org, Len Brown , linux-acpi@vger.kernel.org Subject: Re: [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h Date: Mon, 06 Jan 2014 12:17:55 +0100 Message-ID: <1448202.tci3nLAAiD@vostro.rjw.lan> User-Agent: KMail/4.11.3 (Linux/3.13.0-rc6+; KDE/4.11.3; x86_64; ; ) In-Reply-To: <20140106032849.GA20605@leaf> References: <1528697.GH1GrQaKgp@vostro.rjw.lan> <20140106032849.GA20605@leaf> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, January 05, 2014 07:28:49 PM Josh Triplett wrote: > On Mon, Jan 06, 2014 at 12:33:57AM +0100, Rafael J. Wysocki wrote: > > On Tuesday, December 17, 2013 03:06:54 PM Rashika Kheria wrote: > > > Include header file internal.h in debugfs.c and change the return > > > value's type in header file internal.h. > > > > > > This eliminates the following warning in debugfs.c: > > > drivers/acpi/debugfs.c:16:13: warning: no previous prototype for ‘acpi_debugfs_init’ [-Wmissing-prototypes] > > > > > > Signed-off-by: Rashika Kheria > > > Reviewed-by: Josh Triplett > > > --- > > > drivers/acpi/debugfs.c | 3 +++ > > > drivers/acpi/internal.h | 2 +- > > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c > > > index b55d6a2..96bcaf7 100644 > > > --- a/drivers/acpi/debugfs.c > > > +++ b/drivers/acpi/debugfs.c > > > @@ -6,6 +6,7 @@ > > > #include > > > #include > > > #include > > > +#include "internal.h" > > > > > > #define _COMPONENT ACPI_SYSTEM_COMPONENT > > > ACPI_MODULE_NAME("debugfs"); > > > @@ -13,7 +14,9 @@ ACPI_MODULE_NAME("debugfs"); > > > struct dentry *acpi_debugfs_dir; > > > EXPORT_SYMBOL_GPL(acpi_debugfs_dir); > > > > > > +#ifdef CONFIG_DEBUG_FS > > > void __init acpi_debugfs_init(void) > > > { > > > acpi_debugfs_dir = debugfs_create_dir("acpi", NULL); > > > } > > > +#endif > > > > What about avoiding to build the entire debugfs.c for CONFIG_DEBUG_FS unset? > > > > That surely would make sense? > > It exports the symbol acpi_debugfs_dir, which is used unconditionally. It's only used by drivers/acpi/custom_method.c which also should only be compiled for CONFIG_DEBUG_FS set. Thanks, Rafael