From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537AbbKWJVb (ORCPT ); Mon, 23 Nov 2015 04:21:31 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:55707 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752551AbbKWJV3 (ORCPT ); Mon, 23 Nov 2015 04:21:29 -0500 Message-Id: <1448270487.3976105.447364665.43219C16@webmail.messagingengine.com> X-Sasl-Enc: cozOjH3vrh8UyIuRPjbbggwS85snEyixK76r4zvy0o0B 1448270487 From: Hannes Frederic Sowa To: Dmitry Vyukov , Al Viro Cc: Eric Dumazet , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, netdev , David Miller , Eric Dumazet , Kostya Serebryany , Alexander Potapenko , Sasha Levin , syzkaller , Alexey Kuznetsov MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Mailer: MessagingEngine.com Webmail Interface - ajax-0a80c2aa In-Reply-To: References: <1446824535.4184.69.camel@edumazet-glaptop2.roam.corp.google.com> <20151110023854.GZ22011@ZenIV.linux.org.uk> <20151110025906.GA22011@ZenIV.linux.org.uk> Subject: Re: Deadlock between bind and splice Date: Mon, 23 Nov 2015 10:21:27 +0100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 23, 2015, at 09:32, Dmitry Vyukov wrote: > On Tue, Nov 10, 2015 at 3:59 AM, Al Viro wrote: > > On Tue, Nov 10, 2015 at 02:38:54AM +0000, Al Viro wrote: > >> On Fri, Nov 06, 2015 at 07:42:15AM -0800, Eric Dumazet wrote: > >> > >> > Thank you for this report. > >> > > >> > pipe is part of fs, not net ;) > >> > >> AF_UNIX bind() vs. socketpair() interplay, OTOH... > > > > FWIW, BSD folks unlock the socket for the duration of mknod - mark it as > > "somebody's trying to bind it" to avoid the fun with racing double bind(), > > but that's about it. Tempting, to be honest... > > > > BTW, why does unix_autobind() do allocation under ->readlock? The allocation > > will be normally used - that if (u->addr) return; part is just dealing with > > an unlikely race, as far as I can see... > > > Hello, > > This is still happening periodically for me. Is there a proposed fix? > I could test it. No, we currently have no fix for that report. :/