From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753793AbbKWJkb (ORCPT ); Mon, 23 Nov 2015 04:40:31 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:57043 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753493AbbKWJka (ORCPT ); Mon, 23 Nov 2015 04:40:30 -0500 Message-ID: <1448271626.3689.7.camel@pengutronix.de> Subject: Re: [PATCH] cpufreq: imx: Add cpufreq driver for imx7D/Solo SOC From: Lucas Stach To: Bai Ping Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Date: Mon, 23 Nov 2015 10:40:26 +0100 In-Reply-To: <1448287669-3600-1-git-send-email-b51503@freescale.com> References: <1448287669-3600-1-git-send-email-b51503@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:fa0f:41ff:fe58:4010 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, den 23.11.2015, 22:07 +0800 schrieb Bai Ping: > The i.MX7Dual/Solo is a new series of the i.MX SOC family. > The existing cpufreq driver for 'i.MX6' or 'cpufreq-dt' can > NOT match the requirement of this new SOC. This patch adds the > cpufreq driver for i.MX7Dual/Solo. > So, what are those requirements, which could not be matched with cpufreq-dt? We should really try to not add another cpufreq driver. I don't see anything special in here. A single regulator and some clocks needing to be controlled in the right way. That's already handled for i.MX5 with cpufreq-dt. Please look up how it is done there and try to do it the same way for MX7, or provide substantial information why it couldn't be done. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |