From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbbKWMXg (ORCPT ); Mon, 23 Nov 2015 07:23:36 -0500 Received: from mail-qg0-f48.google.com ([209.85.192.48]:36188 "EHLO mail-qg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753290AbbKWMXf (ORCPT ); Mon, 23 Nov 2015 07:23:35 -0500 From: Jeff Layton X-Google-Original-From: Jeff Layton To: Andrew Morton Cc: Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko Subject: [PATCH v2] mm: fix up sparse warning in gfpflags_allow_blocking Date: Mon, 23 Nov 2015 07:23:29 -0500 Message-Id: <1448281409-13132-1-git-send-email-jeff.layton@primarydata.com> X-Mailer: git-send-email 2.4.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sparse says: include/linux/gfp.h:274:26: warning: incorrect type in return expression (different base types) include/linux/gfp.h:274:26: expected bool include/linux/gfp.h:274:26: got restricted gfp_t Add a comparison to zero to have it return bool. Cc: Michal Hocko Cc: Mel Gorman Signed-off-by: Jeff Layton --- include/linux/gfp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) [v2: use a compare instead of forced cast, as suggested by Michal] diff --git a/include/linux/gfp.h b/include/linux/gfp.h index 6523109e136d..b76c92073b1b 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h @@ -271,7 +271,7 @@ static inline int gfpflags_to_migratetype(const gfp_t gfp_flags) static inline bool gfpflags_allow_blocking(const gfp_t gfp_flags) { - return gfp_flags & __GFP_DIRECT_RECLAIM; + return (gfp_flags & __GFP_DIRECT_RECLAIM) != 0; } #ifdef CONFIG_HIGHMEM -- 2.4.3