From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755418AbbKWV36 (ORCPT ); Mon, 23 Nov 2015 16:29:58 -0500 Received: from mail-lf0-f45.google.com ([209.85.215.45]:35442 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755390AbbKWV3z (ORCPT ); Mon, 23 Nov 2015 16:29:55 -0500 From: Rasmus Villemoes To: Andrew Morton Cc: Rasmus Villemoes , Kees Cook , linux-kernel@vger.kernel.org Subject: [PATCH 09/14] lib/test_printf.c: don't BUG Date: Mon, 23 Nov 2015 22:29:26 +0100 Message-Id: <1448314171-25856-10-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.6.1 In-Reply-To: <1448314171-25856-1-git-send-email-linux@rasmusvillemoes.dk> References: <1448314171-25856-1-git-send-email-linux@rasmusvillemoes.dk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org BUG is a completely unnecessarily big hammer, and we're more likely to get the internal bug reported if we just pr_err() and ensure the test suite fails. Acked-by: Kees Cook Signed-off-by: Rasmus Villemoes --- lib/test_printf.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/test_printf.c b/lib/test_printf.c index c5a666af9ba5..9232a2add28c 100644 --- a/lib/test_printf.c +++ b/lib/test_printf.c @@ -91,7 +91,12 @@ __test(const char *expect, int elen, const char *fmt, ...) int rand; char *p; - BUG_ON(elen >= BUF_SIZE); + if (elen >= BUF_SIZE) { + pr_err("error in test suite: expected output length %d too long. Format was '%s'.\n", + elen, fmt); + failed_tests++; + return; + } va_start(ap, fmt); -- 2.6.1