From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>,
Jean Delvare <jdelvare@suse.de>, Mark Brown <broonie@kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] modpost: don't add a trailing wildcard for OF module aliases
Date: Tue, 24 Nov 2015 09:07:30 +0100 [thread overview]
Message-ID: <1448352450.19513.53.camel@collabora.co.uk> (raw)
In-Reply-To: <1447943308-27689-1-git-send-email-javier@osg.samsung.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 1292 bytes --]
On Thu, 2015-11-19 at 11:28 -0300, Javier Martinez Canillas wrote:
> Â scripts/mod/file2alias.c | 3 +--
> Â 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> index 5b96206e9aab..65eaab8b7798 100644
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -125,7 +125,7 @@ do
> {Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â sprintf(str + strlen(str), "*");Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â \
> Â } while(0)
> Â
> -/* Always end in a wildcard, for future extension */
> +/* End in a wildcard, for future extension */
> Â static inline void add_wildcard(char *str)
> Â {
> Â int len = strlen(str);
> @@ -704,7 +704,6 @@ static int do_of_entry (const char *filename,
> void *symval, char *alias)
> Â if (isspace (*tmp))
> Â *tmp = '_';
> Â
> - add_wildcard(alias);
> Â return 1;
> Â }
> Â ADD_TO_DEVTABLE("of", of_device_id, do_of_entry);
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
--
Sjoerd Simons
Collabora Ltd.
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
prev parent reply other threads:[~2015-11-24 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 14:28 Javier Martinez Canillas
2015-11-24 8:07 ` Sjoerd Simons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448352450.19513.53.camel@collabora.co.uk \
--to=sjoerd.simons@collabora.co.uk \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=jdelvare@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®