From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753786AbbKXJmv (ORCPT ); Tue, 24 Nov 2015 04:42:51 -0500 Received: from mail-lf0-f43.google.com ([209.85.215.43]:35514 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753337AbbKXJmq (ORCPT ); Tue, 24 Nov 2015 04:42:46 -0500 From: Rasmus Villemoes To: Christoph Hellwig , Hannes Reinecke , Bart Van Assche , "James E.J. Bottomley" , Julian Calaby Cc: Rasmus Villemoes , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/3] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k Date: Tue, 24 Nov 2015 10:42:24 +0100 Message-Id: <1448358147-23663-1-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.6.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reduces the impact of choosing CONFIG_SCSI_CONSTANTS by about 8KB. 2dd951ecd511 ("scsi: Conditionally compile in constants.c") updated the Kconfig help text from 12KB to 75KB. The 12K predated git so was certainly outdated. But I'm not sure where the 75K comes from; using size(1) on a defconfig (with/without this config option) vmlinux shows a difference of about 47K, and 39K after these patches are applied. In any case, I've left the Kconfig text alone, since I'm not sure I'm counting the same way the 75K was computed (I'm fairly certain of the 8K delta, however). Tested with a trivial module calling scsi_extd_sense_format with a few random known codes and comparing the result to the expected value. v2: prepend patch to unsplit a few string literals for greppability, leave the NULL sentinel in the .c file in 2/3 (it's removed in 3/3 either way). Rasmus Villemoes (3): scsi: make some Additional Sense strings more grep'able scsi: move Additional Sense Codes to separate file scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k drivers/scsi/constants.c | 859 ++------------------------------------------- drivers/scsi/sense_codes.h | 826 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 847 insertions(+), 838 deletions(-) create mode 100644 drivers/scsi/sense_codes.h -- 2.6.1