From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754202AbbKXJxn (ORCPT ); Tue, 24 Nov 2015 04:53:43 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35670 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753737AbbKXJxf (ORCPT ); Tue, 24 Nov 2015 04:53:35 -0500 Subject: Re: [PATCH 2/2] arcmsr: adds code for support areca new adapter ARC1203 From: Ching Huang To: Joe Perches Cc: hch@infradead.org, thenzl@redhat.com, jbottomley@parallels.com, dan.carpenter@oracle.com, agordeev@redhat.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de In-Reply-To: <1448357586.14504.12.camel@perches.com> References: <1448353024.12861.56.camel@Centos6.3-64> <1448357586.14504.12.camel@perches.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 24 Nov 2015 17:53:18 +0800 Message-ID: <1448358798.14472.3.camel@Centos6.3-64> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-24.el6) Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-11-24 at 01:33 -0800, Joe Perches wrote: > On Tue, 2015-11-24 at 16:17 +0800, Ching Huang wrote: > > From: Ching Huang > > > > Support areca new PCIe to SATA RAID adapter ARC1203 > > Why add the dma_free_coherent to an old data path? > Is that a general bug fix that should be backported? That's right. It's need to release the allocated resource for failed condition. > > btw: the printk above the dma_free_coherent use > shouldn't use a \ line continuation. > it adds undesired whitespace to the format. > > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c > [] > > @@ -2660,10 +2670,19 @@ static bool arcmsr_hbaB_get_config(struc > > iop_firm_version = (char __iomem *)(®->message_rwbuffer[17]);> > /*firm_version,17,68-83*/ > > iop_device_map = (char __iomem *)(®->message_rwbuffer[21]);> > /*firm_version,21,84-99*/ > > > > + arcmsr_wait_firmware_ready(acb); > > + writel(ARCMSR_MESSAGE_START_DRIVER_MODE, reg->drv2iop_doorbell); > > + if (!arcmsr_hbaB_wait_msgint_ready(acb)) { > > + printk(KERN_ERR "arcmsr%d: can't set driver mode.\n", acb->host->host_no); > > + goto gcfg1; > > + } > > writel(ARCMSR_MESSAGE_GET_CONFIG, reg->drv2iop_doorbell); > > if (!arcmsr_hbaB_wait_msgint_ready(acb)) { > > printk(KERN_NOTICE "arcmsr%d: wait 'get adapter firmware \ > > miscellaneous data' timeout \n", acb->host->host_no); > > +gcfg1: > > + dma_free_coherent(&acb->pdev->dev, acb->roundup_ccbsize, > > + acb->dma_coherent2, acb->dma_coherent_handle2); > > return false; > > } > > count = 8; >