From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Matias Bjorling <mb@lightnvm.io>
Cc: linux-kernel@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH v2 4/5] lightnvm: release dev if dma pools fails
Date: Tue, 24 Nov 2015 16:04:59 +0530 [thread overview]
Message-ID: <1448361300-26718-4-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1448361300-26718-1-git-send-email-sudipm.mukherjee@gmail.com>
If create_dma_pools() fails then we just returned the error code but we
missed freeing the device.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/lightnvm/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index d288996..9dd1623 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -318,6 +318,7 @@ int nvm_register(struct request_queue *q, char *disk_name,
"ppalist");
if (!dev->ppalist_pool) {
pr_err("nvm: could not create ppa pool\n");
+ nvm_free(dev);
return -ENOMEM;
}
}
--
1.9.1
next prev parent reply other threads:[~2015-11-24 10:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 10:34 [PATCH v2 1/5] lightnvm: fix memory leak Sudip Mukherjee
2015-11-24 10:34 ` [PATCH v2 2/5] lightnvm: check for max sector Sudip Mukherjee
2015-11-24 11:00 ` Matias Bjørling
2015-11-24 10:34 ` [PATCH v2 3/5] lightnvm: create dma pool first Sudip Mukherjee
2015-11-24 11:01 ` Matias Bjørling
2015-11-24 10:34 ` Sudip Mukherjee [this message]
2015-11-24 11:06 ` [PATCH v2 4/5] lightnvm: release dev if dma pools fails Matias Bjørling
2015-11-24 10:35 ` [PATCH v2 5/5] lightnvm: return error if manager not found Sudip Mukherjee
2015-11-24 11:10 ` Matias Bjørling
2015-11-24 10:57 ` [PATCH v2 1/5] lightnvm: fix memory leak Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448361300-26718-4-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®