From: Jin Qian <jinqian@android.com>
To: "Greg Hackmann" <ghackmann@google.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Yu Ning" <yu.ning@intel.com>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Jason Hu" <jia-cheng.hu@intel.com>,
"Joe Perches" <joe@perches.com>,
"Christoffer Dall" <christoffer.dall@linaro.org>,
"Peter Senna Tschudin" <peter.senna@gmail.com>,
linux-kernel@vger.kernel.org
Cc: Jin Qian <jinqian@android.com>
Subject: [PATCH 5/8] platform: goldfish: pipe: don't log when dropping PIPE_ERROR_AGAIN
Date: Tue, 24 Nov 2015 17:10:09 -0800 [thread overview]
Message-ID: <1448413812-24289-6-git-send-email-jinqian@android.com> (raw)
In-Reply-To: <1448413812-24289-1-git-send-email-jinqian@android.com>
From: Greg Hackmann <ghackmann@google.com>
On PIPE_ERROR_AGAIN, just stopping in the middle of a transfer and
returning the number of bytes actually handled is the right behavior.
Other errors should be returned on the next read() or write() call.
Continue logging those until we confirm nothing actually relies on the
existing (wrong) behavior of dropping errors on the floor.
Signed-off-by: Greg Hackmann <ghackmann@google.com>
(cherry picked from commit 1bebc767c41766fc00787473e364db83d5fe6989)
Signed-off-by: Jin Qian <jinqian@android.com>
---
drivers/platform/goldfish/goldfish_pipe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index 86cc57f..afc6f8d 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -346,7 +346,8 @@ static ssize_t goldfish_pipe_read_write(struct file *filp, char __user *buffer,
* cannot change it until we check if any user space
* ABI relies on this behavior.
*/
- pr_info_ratelimited("android_pipe: backend returned error %d on %s\n",
+ if (status != PIPE_ERROR_AGAIN)
+ pr_info_ratelimited("goldfish_pipe: backend returned error %d on %s\n",
status, is_write ? "write" : "read");
ret = 0;
break;
--
2.6.0.rc2.230.g3dd15c0
next prev parent reply other threads:[~2015-11-25 1:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1448413812-24289-1-git-send-email-jinqian@android.com>
2015-11-25 1:10 ` [PATCH 1/8] goldfish: refactor goldfish platform configs Jin Qian
2015-11-25 12:32 ` Alex Bennée
2015-11-25 1:10 ` [PATCH 2/8] android_pipe: don't be clever with #define offsets Jin Qian
2015-11-25 1:10 ` [PATCH 3/8] android_pipe: Pin pages to memory while copying and other cleanups Jin Qian
2015-11-25 1:10 ` [PATCH 4/8] platform: goldfish: pipe: add devicetree bindings Jin Qian
2015-11-25 11:22 ` Christoffer Dall
2015-11-25 1:10 ` Jin Qian [this message]
2015-11-25 1:10 ` [PATCH 6/8] [MIPS] Enable platform support for Goldfish virtual devices Jin Qian
2015-11-25 1:10 ` [PATCH 7/8] goldfish_pipe: Pass physical addresses to the device if supported Jin Qian
2015-11-25 1:10 ` [PATCH 8/8] goldfish: Enable ACPI-based enumeration for android pipe Jin Qian
2016-01-06 14:03 [PATCH 0/8] Goldfish: partial resync with Google tree Alan
2016-01-06 14:05 ` [PATCH 5/8] platform: goldfish: pipe: don't log when dropping PIPE_ERROR_AGAIN Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448413812-24289-6-git-send-email-jinqian@android.com \
--to=jinqian@android.com \
--cc=alex.bennee@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=ghackmann@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jia-cheng.hu@intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=yu.ning@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®