From: Ingi Kim <ingi2.kim@samsung.com>
To: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
sameo@linux.intel.com, lee.jones@linaro.org, rpurdie@rpsys.net,
j.anaszewski@samsung.com
Cc: inki.dae@samsung.com, sw0312.kim@samsung.com,
beomho.seo@samsung.com, andi.shyti@samsung.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, Ingi Kim <ingi2.kim@samsung.com>
Subject: [PATCH v6 0/2] Add RT5033 Flash LED driver
Date: Wed, 25 Nov 2015 19:22:26 +0900 [thread overview]
Message-ID: <1448446948-13729-1-git-send-email-ingi2.kim@samsung.com> (raw)
This is a sixth version of the patch set to support RT5033 Flash Led.
It is based on RFC [1] from Jacek's patch set.
Changes since v6:
- Make functions to convert from LED config data to register value
- Add variables to save LED config data in rt5033_led struct
- Rename some functions suitably
- Change to set register of flash brightness / timeout when it was changed.
Changes since v5:
- Rebase on Jacek's devel branch
git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git
- Remove work queue from driver.
- Change brightness_set_sync ops to brightness_set_blocking ops.
- Remove "iout_torch_max" and "iout_flash_max" values in rt5033_led struct.
- Add missed case for distinguishing between setting brightness.
for iout_joint case and for individual LEDs.
- Add missed mutex_lock.
- Remove guard to check dev->of_node.
- Change type of value to const __be32 to get return value of of_find_property.
Changes since v4:
- Use of_node_put() when DT parse miss
- Move struct(rt5033_led) from include/linux/mfd/rt5033.h
to local driver/leds/leds-rt5033.c
- Remove MODULE_DEVICE_TABLE
- Add interface to handle two LEDs.
Changes since v3:
- Use mutex and work queue
- Split brightness set func (sync / async)
- Add flash API (flash_brightness_set)
- Move struct(rt5033_led_config_data) to local area
- Code clean
Changes since v2:
- Split MFC code from rt5033 flash led patch
- Fix typo error
- Change naming of mfd register back again
- Fix compile error
Original cover letter:
This patch supports flash led of RT5033 PMIC.
[1] https://lkml.org/lkml/2015/8/20/426
Ingi Kim (2):
leds: rt5033: Add DT binding for RT5033
leds: rt5033: Add RT5033 Flash led device driver
.../devicetree/bindings/leds/leds-rt5033.txt | 46 ++
drivers/leds/Kconfig | 8 +
drivers/leds/Makefile | 1 +
drivers/leds/leds-rt5033.c | 541 +++++++++++++++++++++
include/linux/mfd/rt5033-private.h | 51 ++
5 files changed, 647 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt
create mode 100644 drivers/leds/leds-rt5033.c
--
2.0.5
next reply other threads:[~2015-11-25 10:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 10:22 Ingi Kim [this message]
2015-11-25 10:22 ` [PATCH v6 1/2] leds: rt5033: Add DT binding for RT5033 Ingi Kim
2015-11-25 10:22 ` [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver Ingi Kim
2015-11-25 15:13 ` Jacek Anaszewski
2015-11-26 8:02 ` Ingi Kim
2015-11-26 9:12 ` Lee Jones
2015-11-26 9:43 ` Jacek Anaszewski
2015-11-30 2:31 ` Ingi Kim
2015-11-30 10:59 ` Jacek Anaszewski
2015-12-01 1:54 ` Ingi Kim
2015-12-01 7:55 ` Jacek Anaszewski
2015-11-26 9:11 ` Lee Jones
2015-11-30 2:35 ` Ingi Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448446948-13729-1-git-send-email-ingi2.kim@samsung.com \
--to=ingi2.kim@samsung.com \
--cc=andi.shyti@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=j.anaszewski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sameo@linux.intel.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®