From: Yang Shi <yang.shi@linaro.org>
To: davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
linaro-kernel@lists.linaro.org, yang.shi@linaro.org
Subject: [PATCH] sparc64/gup: check address scope legitimacy
Date: Wed, 25 Nov 2015 14:31:24 -0800 [thread overview]
Message-ID: <1448490684-17171-1-git-send-email-yang.shi@linaro.org> (raw)
Check if user address is accessible in atomic version __get_user_pages_fast()
before walking the page table.
And, check if end > start in get_user_pages_fast(), otherwise fallback to slow
path.
Signed-off-by: Yang Shi <yang.shi@linaro.org>
---
arch/sparc/mm/gup.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/sparc/mm/gup.c b/arch/sparc/mm/gup.c
index 2e5c4fc..08b8da5 100644
--- a/arch/sparc/mm/gup.c
+++ b/arch/sparc/mm/gup.c
@@ -173,6 +173,9 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
addr = start;
len = (unsigned long) nr_pages << PAGE_SHIFT;
end = start + len;
+ if (unlikely(!access_ok(write ? VERIFY_WRITE : VERIFY_READ,
+ (void __user *)start, len)))
+ return 0;
local_irq_save(flags);
pgdp = pgd_offset(mm, addr);
@@ -203,6 +206,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write,
addr = start;
len = (unsigned long) nr_pages << PAGE_SHIFT;
end = start + len;
+ if (end < start)
+ goto slow_irqon;
/*
* XXX: batch / limit 'nr', to avoid large irq off latency
--
2.0.2
next reply other threads:[~2015-11-25 22:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 22:31 Yang Shi [this message]
2015-11-25 22:45 ` [V2 PATCH] " Yang Shi
2015-12-03 20:38 ` Sam Ravnborg
2015-12-03 22:23 ` Shi, Yang
2015-12-05 9:59 ` Sam Ravnborg
2015-11-26 0:26 ` [PATCH] " kbuild test robot
2015-11-26 0:31 ` Shi, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448490684-17171-1-git-send-email-yang.shi@linaro.org \
--to=yang.shi@linaro.org \
--cc=davem@davemloft.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®