From: Michael Ellerman <mpe@ellerman.id.au>
To: Geliang Tang <geliangtang@163.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Scott Wood <scottwood@freescale.com>,
David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] powerpc: fix a problematic usage of WARN()
Date: Thu, 26 Nov 2015 16:25:44 +1100 [thread overview]
Message-ID: <1448515544.9839.11.camel@ellerman.id.au> (raw)
In-Reply-To: <84a366614b84091cd4bd354e8b65dd51c1762a52.1448456395.git.geliangtang@163.com>
On Wed, 2015-11-25 at 21:12 +0800, Geliang Tang wrote:
> WARN() takes a condition and a format string. The condition was
> omitted. So I added it.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> arch/powerpc/kernel/setup_64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
> index 5c03a6a..726a9fb 100644
> --- a/arch/powerpc/kernel/setup_64.c
> +++ b/arch/powerpc/kernel/setup_64.c
> @@ -127,7 +127,7 @@ static void setup_tlb_core_data(void)
> !mmu_has_feature(MMU_FTR_USE_TLBRSRV) &&
> book3e_htw_mode != PPC_HTW_E6500) {
> /* Should we panic instead? */
> - WARN_ONCE("%s: unsupported MMU configuration -- expect problems\n",
> + WARN_ONCE(1, "%s: unsupported MMU configuration -- expect problems\n",
> __func__);
> }
> }
Oh yuck.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
next prev parent reply other threads:[~2015-11-26 5:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 13:12 [PATCH 1/7] drm/msm/mdp: fix a problematic usage of WARN_ON() Geliang Tang
2015-11-25 13:12 ` [PATCH 2/7] drm/vmwgfx: " Geliang Tang
2015-11-25 13:12 ` [PATCH 3/7] iio: " Geliang Tang
2015-11-25 13:12 ` [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() Geliang Tang
2015-11-25 13:12 ` [PATCH 5/7] vfio: fix a problematic usage of WARN() Geliang Tang
2015-11-25 13:12 ` [PATCH 6/7] ARM: davinci: " Geliang Tang
2015-11-25 13:12 ` [PATCH 7/7] powerpc: " Geliang Tang
2015-11-26 5:25 ` Michael Ellerman [this message]
2015-11-25 13:39 ` [PATCH 6/7] ARM: davinci: " Arnd Bergmann
2015-11-25 14:13 ` [PATCH v2] " Geliang Tang
2015-11-25 20:21 ` kbuild test robot
2015-11-25 20:28 ` Arnd Bergmann
2015-11-26 0:35 ` [PATCH v3] " Geliang Tang
2015-12-15 9:58 ` Sekhar Nori
2015-11-25 13:35 ` [PATCH 5/7] vfio: " Alex Williamson
2015-11-25 13:47 ` [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() Grumbach, Emmanuel
2015-11-25 13:14 ` [PATCH 3/7] iio: fix a problematic usage of WARN_ON() Lars-Peter Clausen
2015-11-25 15:50 ` [PATCH 2/7] drm/vmwgfx: " Sinclair Yeh
2015-11-26 14:51 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448515544.9839.11.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=geliangtang@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®