From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753838AbbK0HiC (ORCPT ); Fri, 27 Nov 2015 02:38:02 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35205 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751050AbbK0HiB (ORCPT ); Fri, 27 Nov 2015 02:38:01 -0500 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Sudip Mukherjee Subject: [PATCH 1/2] staging: most: return error value Date: Fri, 27 Nov 2015 13:07:49 +0530 Message-Id: <1448609870-20172-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On error we were returning retval, but retval is not having the error value. We will get the error value using PTR_ERR. Signed-off-by: Sudip Mukherjee --- This series doesnot depend on my earlier pending series. drivers/staging/most/aim-cdev/cdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev/cdev.c index dc3fb25..3f7c8bb 100644 --- a/drivers/staging/most/aim-cdev/cdev.c +++ b/drivers/staging/most/aim-cdev/cdev.c @@ -468,8 +468,8 @@ static int aim_probe(struct most_interface *iface, int channel_id, NULL, "%s", name); - retval = IS_ERR(channel->dev); - if (retval) { + if (IS_ERR(channel->dev)) { + retval = PTR_ERR(channel->dev); pr_info("failed to create new device node %s\n", name); goto error_create_device; } -- 1.9.1