From: Sudeep Holla <sudeep.holla@arm.com>
To: Linus Walleij <linus.walleij@linaro.org>, linux-gpio@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org, Sudeep Holla <Sudeep.Holla@arm.com>
Subject: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag
Date: Fri, 27 Nov 2015 17:21:00 +0000 [thread overview]
Message-ID: <1448644860-29323-2-git-send-email-sudeep.holla@arm.com> (raw)
In-Reply-To: <1448644860-29323-1-git-send-email-sudeep.holla@arm.com>
From: Sudeep Holla <Sudeep.Holla@arm.com>
The IRQF_NO_SUSPEND flag is used to identify the interrupts that should
be left enabled so as to allow them to work as expected during the
suspend-resume cycle, but doesn't guarantee that it will wake the system
from a suspended state, enable_irq_wake is recommended to be used for
the wakeup.
This patch removes the use of IRQF_NO_SUSPEND flags replacing it with
irq_set_irq_wake instead.
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/pinctrl/pinctrl-single.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 945a7d0f0704..a1e32c6b554a 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -1622,12 +1622,14 @@ static void pcs_irq_unmask(struct irq_data *d)
*/
static int pcs_irq_set_wake(struct irq_data *d, unsigned int state)
{
+ struct pcs_soc_data *pcs_soc = irq_data_get_irq_chip_data(d);
+
if (state)
pcs_irq_unmask(d);
else
pcs_irq_mask(d);
- return 0;
+ return irq_set_irq_wake(pcs_soc->irq, state);
}
/**
@@ -1763,8 +1765,7 @@ static int pcs_irq_init_chained_handler(struct pcs_device *pcs,
int res;
res = request_irq(pcs_soc->irq, pcs_irq_handler,
- IRQF_SHARED | IRQF_NO_SUSPEND |
- IRQF_NO_THREAD,
+ IRQF_SHARED | IRQF_NO_THREAD,
name, pcs_soc);
if (res) {
pcs_soc->irq = -1;
--
1.9.1
next prev parent reply other threads:[~2015-11-27 17:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 17:20 [PATCH 1/2] pinctrl: single: Use a separate lockdep class Sudeep Holla
2015-11-27 17:21 ` Sudeep Holla [this message]
2015-12-01 14:06 ` [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag Linus Walleij
2015-12-03 18:13 ` Tony Lindgren
2015-12-03 18:35 ` Grygorii Strashko
2015-12-03 21:37 ` Tony Lindgren
2015-12-04 10:44 ` Grygorii Strashko
2015-12-04 10:54 ` Sudeep Holla
2015-12-04 11:18 ` Grygorii Strashko
2015-12-04 11:21 ` Sudeep Holla
2015-12-04 15:35 ` Tony Lindgren
2015-12-04 15:59 ` Grygorii Strashko
2015-12-04 16:11 ` Sudeep Holla
2015-12-04 16:30 ` Grygorii Strashko
2015-12-04 17:07 ` Tony Lindgren
2015-12-04 17:09 ` Tony Lindgren
2015-12-03 18:59 ` Sudeep Holla
2015-12-03 21:40 ` Tony Lindgren
2015-12-04 15:40 ` Tony Lindgren
2015-12-04 15:44 ` Sudeep Holla
2015-12-04 16:19 ` Grygorii Strashko
2015-12-04 16:26 ` Sudeep Holla
2015-12-04 17:06 ` Tony Lindgren
2015-12-04 16:15 ` Sudeep Holla
2015-12-04 17:10 ` Tony Lindgren
2015-12-01 14:06 ` [PATCH 1/2] pinctrl: single: Use a separate lockdep class Linus Walleij
2015-12-01 14:09 ` Sudeep Holla
2015-12-03 18:07 ` Tony Lindgren
2015-12-03 21:46 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448644860-29323-2-git-send-email-sudeep.holla@arm.com \
--to=sudeep.holla@arm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®