mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fabian Frederick <fabf@skynet.be>
To: linux-kernel@vger.kernel.org
Cc: Philipp Reisner <philipp.reisner@linbit.com>,
	Fabian Frederick <fabf@skynet.be>,
	Lars Ellenberg <lars.ellenberg@linbit.com>,
	drbd-dev@lists.linbit.com
Subject: [PATCH 03/21] drbd: use seq_put instead of seq_print where possible
Date: Fri, 27 Nov 2015 22:26:08 +0100	[thread overview]
Message-ID: <1448659575-13485-4-git-send-email-fabf@skynet.be> (raw)
In-Reply-To: <1448659575-13485-1-git-send-email-fabf@skynet.be>

seq_putc/seq_puts give the following improvements:

text   data  bss    dec	    hex	filename
4661      0  8	   4669	   123d	drivers/block/drbd/drbd_proc.o
4603      0  8	   4611	   1203	drivers/block/drbd/drbd_proc-after.o

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 drivers/block/drbd/drbd_proc.c | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/block/drbd/drbd_proc.c b/drivers/block/drbd/drbd_proc.c
index 6537b25..233a710 100644
--- a/drivers/block/drbd/drbd_proc.c
+++ b/drivers/block/drbd/drbd_proc.c
@@ -122,18 +122,18 @@ static void drbd_syncer_progress(struct drbd_device *device, struct seq_file *se
 
 	x = res/50;
 	y = 20-x;
-	seq_printf(seq, "\t[");
+	seq_puts(seq, "\t[");
 	for (i = 1; i < x; i++)
-		seq_printf(seq, "=");
-	seq_printf(seq, ">");
+		seq_putc(seq, '=');
+	seq_putc(seq, '>');
 	for (i = 0; i < y; i++)
 		seq_printf(seq, ".");
-	seq_printf(seq, "] ");
+	seq_puts(seq, "] ");
 
 	if (state.conn == C_VERIFY_S || state.conn == C_VERIFY_T)
-		seq_printf(seq, "verified:");
+		seq_puts(seq, "verified:");
 	else
-		seq_printf(seq, "sync'ed:");
+		seq_puts(seq, "sync'ed:");
 	seq_printf(seq, "%3u.%u%% ", res / 10, res % 10);
 
 	/* if more than a few GB, display in MB */
@@ -146,7 +146,7 @@ static void drbd_syncer_progress(struct drbd_device *device, struct seq_file *se
 			    (unsigned long) Bit2KB(rs_left),
 			    (unsigned long) Bit2KB(rs_total));
 
-	seq_printf(seq, "\n\t");
+	seq_puts(seq, "\n\t");
 
 	/* see drivers/md/md.c
 	 * We do not want to overflow, so the order of operands and
@@ -175,9 +175,9 @@ static void drbd_syncer_progress(struct drbd_device *device, struct seq_file *se
 		rt / 3600, (rt % 3600) / 60, rt % 60);
 
 	dbdt = Bit2KB(db/dt);
-	seq_printf(seq, " speed: ");
+	seq_puts(seq, " speed: ");
 	seq_printf_with_thousands_grouping(seq, dbdt);
-	seq_printf(seq, " (");
+	seq_puts(seq, " (");
 	/* ------------------------- ~3s average ------------------------ */
 	if (proc_details >= 1) {
 		/* this is what drbd_rs_should_slow_down() uses */
@@ -188,7 +188,7 @@ static void drbd_syncer_progress(struct drbd_device *device, struct seq_file *se
 		db = device->rs_mark_left[i] - rs_left;
 		dbdt = Bit2KB(db/dt);
 		seq_printf_with_thousands_grouping(seq, dbdt);
-		seq_printf(seq, " -- ");
+		seq_puts(seq, " -- ");
 	}
 
 	/* --------------------- long term average ---------------------- */
@@ -200,11 +200,11 @@ static void drbd_syncer_progress(struct drbd_device *device, struct seq_file *se
 	db = rs_total - rs_left;
 	dbdt = Bit2KB(db/dt);
 	seq_printf_with_thousands_grouping(seq, dbdt);
-	seq_printf(seq, ")");
+	seq_putc(seq, ')');
 
 	if (state.conn == C_SYNC_TARGET ||
 	    state.conn == C_VERIFY_S) {
-		seq_printf(seq, " want: ");
+		seq_puts(seq, " want: ");
 		seq_printf_with_thousands_grouping(seq, device->c_sync_rate);
 	}
 	seq_printf(seq, " K/sec%s\n", stalled ? " (stalled)" : "");
@@ -231,7 +231,7 @@ static void drbd_syncer_progress(struct drbd_device *device, struct seq_file *se
 			(unsigned long long)bm_bits * BM_SECT_PER_BIT);
 		if (stop_sector != 0 && stop_sector != ULLONG_MAX)
 			seq_printf(seq, " stop sector: %llu", stop_sector);
-		seq_printf(seq, "\n");
+		seq_putc(seq, '\n');
 	}
 }
 
@@ -276,7 +276,7 @@ static int drbd_seq_show(struct seq_file *seq, void *v)
 	rcu_read_lock();
 	idr_for_each_entry(&drbd_devices, device, i) {
 		if (prev_i != i - 1)
-			seq_printf(seq, "\n");
+			seq_putc(seq, '\n');
 		prev_i = i;
 
 		state = device->state;
-- 
2.1.4


  parent reply	other threads:[~2015-11-27 21:27 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27 21:26 [PATCH 00/21] drbd: clean-up patchset Fabian Frederick
2015-11-27 21:26 ` [PATCH 01/21] drbd: debugfs: constify drbd_version_fops Fabian Frederick
2015-11-27 21:26 ` [PATCH 02/21] drbd: simplify drbd_md_set_sector_offsets() Fabian Frederick
2015-11-27 21:26 ` Fabian Frederick [this message]
2015-11-27 21:26 ` [PATCH 04/21] drbd: include linux/uaccess.h instead of asm/uaccess.h Fabian Frederick
2015-11-27 21:26 ` [PATCH 05/21] drbd: rework is_valid_state() Fabian Frederick
2015-11-27 21:26 ` [PATCH 06/21] drbd: use const char * const for drbd strings Fabian Frederick
2015-11-27 21:26 ` [PATCH 07/21] drbd: kerneldoc warning fix in w_e_end_data_req() Fabian Frederick
2015-11-27 21:26 ` [PATCH 08/21] drbd: use unsigned for one bit fields Fabian Frederick
2015-11-27 21:26 ` [PATCH 09/21] drbd: use bool for peer is_ states Fabian Frederick
2015-11-27 21:29 ` [PATCH 10/21] drbd: fix typo Fabian Frederick
2015-11-27 21:29   ` [PATCH 11/21] drbd: use | for bitmask combination Fabian Frederick
2015-11-27 21:29   ` [PATCH 12/21] drbd: use true/false for bool Fabian Frederick
2015-11-27 21:29   ` [PATCH 13/21] drbd: fix drbd_bm_init() comments Fabian Frederick
2015-11-27 21:29   ` [PATCH 14/21] drbd: clean-up receive_SyncParam() Fabian Frederick
2015-11-27 21:29   ` [PATCH 15/21] drbd: introduce peer state union Fabian Frederick
2015-11-27 21:29   ` [PATCH 16/21] drbd: fix maybe_pull_ahead() locking comments Fabian Frederick
2015-11-27 21:29   ` [PATCH 17/21] drbd: use bool for growing Fabian Frederick
2015-11-27 21:29   ` [PATCH 18/21] drbd: remove redundant declarations Fabian Frederick
2015-11-27 21:29   ` [PATCH 19/21] drbd: remove bm_vk_free() Fabian Frederick
2015-11-27 21:30 ` [PATCH 20/21] drbd: remove unused definitions Fabian Frederick
2015-11-27 21:30   ` [PATCH 21/21] drbd: replace if/BUG by BUG_ON Fabian Frederick
2015-12-01  8:55 ` [Drbd-dev] [PATCH 00/21] drbd: clean-up patchset Philipp Reisner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448659575-13485-4-git-send-email-fabf@skynet.be \
    --to=fabf@skynet.be \
    --cc=drbd-dev@lists.linbit.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp.reisner@linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®