From: Li Bin <huawei.libin@huawei.com>
To: <jpoimboe@redhat.com>, <sjenning@redhat.com>, <jikos@kernel.org>,
<vojtech@suse.com>
Cc: <live-patching@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<guohanjun@huawei.com>, <dingtianhong@huawei.com>,
<xiexiuqi@huawei.com>, <zhouchengming1@huawei.com>
Subject: [PATCH] livepatch: fix race between enabled_store() and klp_unregister_patch()
Date: Mon, 30 Nov 2015 11:54:37 +0800 [thread overview]
Message-ID: <1448855677-8392-1-git-send-email-huawei.libin@huawei.com> (raw)
There is a potential race as following:
CPU0 | CPU1
-----------------------------|-----------------------------------
enabled_store() | klp_unregister_patch()
| |-mutex_lock(&klp_mutex);
|-mutex_lock(&klp_mutex); | |-klp_free_patch();
| |-mutex_unlock(&klp_mutex);
|-[process the patch's state]|
|-mutex_unlock(&klp_mutex) |
Fix this race condition by adding klp_is_patch_registered() check in
enabled_store() after get the lock klp_mutex.
Signed-off-by: Li Bin <huawei.libin@huawei.com>
---
kernel/livepatch/core.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index db545cb..50af971 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -614,6 +614,11 @@ static ssize_t enabled_store(struct kobject *kobj, struct kobj_attribute *attr,
mutex_lock(&klp_mutex);
+ if (!klp_is_patch_registered(patch)) {
+ ret = -EINVAL;
+ goto err;
+ }
+
if (val == patch->state) {
/* already in requested state */
ret = -EINVAL;
--
1.7.1
next reply other threads:[~2015-11-30 3:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 3:54 Li Bin [this message]
2015-11-30 13:53 ` Petr Mladek
2015-12-01 1:11 ` Josh Poimboeuf
2015-12-01 2:46 ` libin
2015-12-01 8:50 ` Jiri Slaby
2015-12-01 14:13 ` Petr Mladek
2015-12-01 14:28 ` Jiri Slaby
2015-12-01 16:57 ` Petr Mladek
2015-12-01 15:53 ` Josh Poimboeuf
2015-12-15 8:14 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448855677-8392-1-git-send-email-huawei.libin@huawei.com \
--to=huawei.libin@huawei.com \
--cc=dingtianhong@huawei.com \
--cc=guohanjun@huawei.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.com \
--cc=xiexiuqi@huawei.com \
--cc=zhouchengming1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®