From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753282AbbK3HSE (ORCPT ); Mon, 30 Nov 2015 02:18:04 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:36175 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752176AbbK3HSB (ORCPT ); Mon, 30 Nov 2015 02:18:01 -0500 X-AuditID: cbfee690-f79646d000001316-d2-565bf82623ab From: Rahul Jain To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Khatri , Rahul Jain Subject: [PATCH] mac80211_hwsim: missing NULL check Date: Mon, 30 Nov 2015 12:46:52 +0530 Message-id: <1448867812-11089-1-git-send-email-rahul.jain@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrALMWRmVeSWpSXmKPExsWyRsSkTlf9R3SYwXRRi+sntrBZLFq5kM3i 8q45bBZvVtxhtzi2QMziR3+AA5vH5b5eJo++LasYPT5vkgtgjuKySUnNySxLLdK3S+DKOLyX v+ACW8W3tv/sDYyXWbsYOTkkBEwkJjdsYYGwxSQu3FvP1sXIxSEksIJRYtGqdywwRf8m9kIl ZjFKTHh+GCwhJPCdUaJrbRiIzSagKbHs8kSmLkYODhEBCYm960pA6plBBk1v+gJWLyxgLNHc 2cYOYrMIqErM2XMQzOYVcJOY27GGCWKZnMTJY5NZQZolBF6zSbzp/M8E0SAg8W3yIRaQBRIC shKbDjBD1EtKHFxxg2UCo+ACRoZVjKKpBckFxUnpRSZ6xYm5xaV56XrJ+bmbGIEBefrfswk7 GO8dsD7EKMDBqMTDK2EWHSbEmlhWXJl7iNEUaMNEZinR5Hxg2OeVxBsamxlZmJqYGhuZW5op ifO+lvoZLCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoHR41bmE5N5/yaaL1yY5bci+uDSQp3Q NT1b3hzokivk6Xr9/NDbo49VpuxeYr1hidOxSYsfZngXagv88u2OOrPrgVTar6ULV2iv5llr v77/ngFb/3wjTgOWN7HakSbLj/1skWaw6Vn25LjoCdMTTYfEs6paTL1jeVprBdf97OzXOlZ4 bGL65OPqSizFGYmGWsxFxYkAD95XYEMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRmVeSWpSXmKPExsVy+t9jQV21H9FhBlsv6VtcP7GFzWLRyoVs Fpd3zWGzeLPiDrvFsQViFj/6AxzYPC739TJ59G1ZxejxeZNcAHNUA6NNRmpiSmqRQmpecn5K Zl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBaJYWyxJxSoFBAYnGxkr4dpgmh IW66FjCNEbq+IUFwPUYGaCBhDWPG4b38BRfYKr61/WdvYLzM2sXIySEhYCLxb2IvG4QtJnHh 3nogm4tDSGAWo8SE54dZQBJCAt8ZJbrWhoHYbAKaEssuT2TqYuTgEBGQkNi7rgSknllgBaPE 9KYvYPXCAsYSzZ1t7CA2i4CqxJw9B8FsXgE3ibkda5gglslJnDw2mXUCI/cCRoZVjBKpBckF xUnpuUZ5qeV6xYm5xaV56XrJ+bmbGMFh/0x6B+PhXe6HGAU4GJV4eCXMosOEWBPLiitzDzFK cDArifDOvwYU4k1JrKxKLcqPLyrNSS0+xGgKdMBEZinR5HxgTOaVxBsam5ibGptamliYmFkq ifPuuxQZJiSQnliSmp2aWpBaBNPHxMEp1cAoa7QrSMr1j5bhHreEjlML/nyOTdNxfa8ot3Hi j8kn/kwzunjj0AS9/3L3XjVeV9jSnruu74Wg4H0u+4UXNhzYFyhjk/X7msvivQwPdL+bqGRV HivodlpW+Kkk+WNfrfzUGZmeX5IMMhY8WX/pLudpyTpvrd5/rTaf113kk7XKCT72nTliaSCf EktxRqKhFnNRcSIA3CEs25ECAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Amit Khatri txrate variable might be NULL and passing inside function without NULL check. Signed-off-by: Amit Khatri Signed-off-by: Rahul Jain --- drivers/net/wireless/mac80211_hwsim.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index 194264c..72e4931 100644 --- a/drivers/net/wireless/mac80211_hwsim.c +++ b/drivers/net/wireless/mac80211_hwsim.c @@ -814,6 +814,9 @@ static void mac80211_hwsim_monitor_rx(struct ieee80211_hw *hw, struct ieee80211_tx_info *info = IEEE80211_SKB_CB(tx_skb); struct ieee80211_rate *txrate = ieee80211_get_tx_rate(hw, info); + if (!txrate) + return; + if (!netif_running(hwsim_mon)) return; -- 1.9.1